From: Heiko Carstens <heiko.carstens@de•ibm.com>
To: Mike Travis <travis@sgi•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Andrew Morton <akpm@linux-foundation•org>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Martin Schwidefsky <schwidefsky@de•ibm.com>
Subject: Re: [PATCH] sysrq: include interrupt.h instead of irq.h
Date: Mon, 26 Jan 2009 13:16:14 +0100 [thread overview]
Message-ID: <20090126131614.4ad29c15@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <4977523B.6000507@sgi.com>
On Wed, 21 Jan 2009 08:50:03 -0800
Mike Travis <travis@sgi•com> wrote:
> Thanks for catching this Heiko!
> Mike
Erm... it still breaks. Are you going to add the patch to your tree?
> Heiko Carstens wrote:
> > From: Heiko Carstens <heiko.carstens@de•ibm.com>
> >
> > With "cpumask: update irq_desc to use cpumask_var_t" in linux-next
> > we get this compile bug on s390:
> >
> > CC drivers/char/sysrq.o
> > In file included from drivers/char/sysrq.c:38:
> > include/linux/irq.h: In function 'init_alloc_desc_masks':
> > include/linux/irq.h:442: error: dereferencing pointer to incomplete type
> >
> > drivers/char/sysrq.c should include interrupt.h instead of irq.h.
> >
> > Cc: Mike Travis <travis@sgi•com>
> > Cc: Martin Schwidefsky <schwidefsky@de•ibm.com>
> > Signed-off-by: Heiko Carstens <heiko.carstens@de•ibm.com>
> > ---
> > drivers/char/sysrq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux-next/drivers/char/sysrq.c
> > ===================================================================
> > --- linux-next.orig/drivers/char/sysrq.c
> > +++ linux-next/drivers/char/sysrq.c
> > @@ -35,7 +35,7 @@
> > #include <linux/vt_kern.h>
> > #include <linux/workqueue.h>
> > #include <linux/kexec.h>
> > -#include <linux/irq.h>
> > +#include <linux/interrupt.h>
> > #include <linux/hrtimer.h>
> > #include <linux/oom.h>
next prev parent reply other threads:[~2009-01-26 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 4:02 linux-next: Tree for January 21 Stephen Rothwell
2009-01-21 13:49 ` [PATCH] sysrq: include interrupt.h instead of irq.h Heiko Carstens
2009-01-21 16:50 ` Mike Travis
2009-01-26 12:16 ` Heiko Carstens [this message]
2009-01-26 15:00 ` Mike Travis
2009-01-26 15:05 ` Ingo Molnar
2009-01-21 14:44 ` X200 suspend issue / linux-next: Tree for January 21 Nico -telmich- Schottelius
2009-01-27 14:05 ` Pavel Machek
2009-01-27 15:31 ` Rafael J. Wysocki
2009-01-27 16:15 ` Aristeu Rozanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090126131614.4ad29c15@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de$(echo .)ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=travis@sgi$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox