Subject: Re: [PATCH 1/2] CPUFREQ: powernow-k8: Forgot to use printk instead of WARN_ONCE in last patch

From: Ingo Molnar <[email-masked]>
Date: Thu, 5 Feb 2009 13:02:03 +0100

* Thomas Renninger <[email-masked]> wrote:

> Signed-off-by: Thomas Renninger <[email-masked]>
> ---
>  arch/x86/kernel/cpu/cpufreq/powernow-k8.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> index 83515f1..5aa832f 100644
> --- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
> @@ -1247,12 +1247,12 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol)
>  			 * thing gets introduced
>  			 */
>  			if (!print_once) {
> -				WARN_ONCE(1, KERN_ERR FW_BUG PFX "Your BIOS "
> -					  "does not provide ACPI _PSS objects "
> -					  "in a way that Linux understands. "
> -					  "Please report this to the Linux ACPI"
> -					  " maintainers and complain to your "
> -					  "BIOS vendor.\n");
> +				printk(KERN_ERR FW_BUG PFX "Your BIOS "
> +				       "does not provide ACPI _PSS objects "
> +				       "in a way that Linux understands. "
> +				       "Please report this to the Linux ACPI"
> +				       " maintainers and complain to your "
> +				       "BIOS vendor.\n");
>  				print_once++;

hm, why the open-coded WARN_ONCE? (which print_once flag + the printk in 
essence is)

So please use WARN_ONCE(), and indent it all one tab to the left which will 
solve at least part of that ugly 6-line split up thing. And if it's a 
WARN_ONCE() then kerneloops.org will pick it up too.

	Ingo