From: KOSAKI Motohiro <kosaki.motohiro@jp•fujitsu.com>
To: Jaswinder Singh Rajput <jaswinder@kernel•org>
Cc: kosaki.motohiro@jp•fujitsu.com, Ingo Molnar <mingo@elte•hu>,
Linus Torvalds <torvalds@linux-foundation•org>,
Sam Ravnborg <sam@ravnborg•org>,
Andrew Morton <akpm@linux-foundation•org>,
Russell King - ARM Linux <linux@arm•linux.org.uk>,
hskinnemoen@atmel•com, cooloney@kernel•org, tony.luck@intel•com,
ralf@linux-mips•org, dhowells@redhat•com, matthew@wil•cx,
chris@zankel•net, LKML <linux-kernel@vger•kernel.org>,
linux-next <linux-next@vger•kernel.org>,
linux-ia64 <linux-ia64@vger•kernel.org>Tony Luck
<tony.luck@intel•com>
Subject: [linux-next][PATCH] revert headers_check fix: ia64, fpu.h
Date: Fri, 6 Feb 2009 17:19:00 +0900 (JST) [thread overview]
Message-ID: <20090206164546.6291.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <1233385816.17794.16.camel@localhost.localdomain>
> diff --git a/arch/ia64/include/asm/fpu.h b/arch/ia64/include/asm/fpu.h
> index 3859558..b6395ad 100644
> --- a/arch/ia64/include/asm/fpu.h
> +++ b/arch/ia64/include/asm/fpu.h
> @@ -6,7 +6,7 @@
> * David Mosberger-Tang <davidm@hpl•hp.com>
> */
>
> -#include <asm/types.h>
> +#include <linux/types.h>
this change break ia64 build perfectly.
this patch seems don't tested at all.
Ingo, I hope you ask patch author how to test posted patch ;-)
==
Subject: [PATCH] revert headers_check fix: ia64, fpu.h
commit fa9ea6c7abd94482ecd84e130676b6a1b3e61c2c break ia64 build perfectly.
it because ia64 has following include file dependency.
entry.S
-> asm/processor.h
-> asm/ptrace.h
-> asm/fpu.h
Then, above commit introduce below dependency.
entry.S
-> asm/processor.h
-> asm/ptrace.h
-> asm/fpu.h
-> linux/types.h
-> linux/posix_types.h
-> linux/stddef.h
Then, assembler can't intepret following statement in stddef.h
enum {
false = 0,
true = 1
};
Therefore, >100 line tons error was outputed.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp•fujitsu.com>
Cc: Jaswinder Singh Rajput <jaswinder@kernel•org>
Cc: Andrew Morton <akpm@linux-foundation•org>
Cc: linux-next <linux-next@vger•kernel.org>
Cc: linux-ia64 <linux-ia64@vger•kernel.org>
Cc: Tony Luck <tony.luck@intel•com>
---
arch/ia64/include/asm/fpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/arch/ia64/include/asm/fpu.h
===================================================================
--- a/arch/ia64/include/asm/fpu.h
+++ b/arch/ia64/include/asm/fpu.h
@@ -6,7 +6,7 @@
* David Mosberger-Tang <davidm@hpl•hp.com>
*/
-#include <linux/types.h>
+#include <asm/types.h>
/* floating point status register: */
#define FPSR_TRAP_VD (1 << 0) /* invalid op trap disabled */
next parent reply other threads:[~2009-02-06 8:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1233385816.17794.16.camel@localhost.localdomain>
2009-02-06 8:19 ` KOSAKI Motohiro [this message]
2009-02-06 8:53 ` [PATCH] revert headers_check fix: ia64, fpu.h Jaswinder Singh Rajput
2009-02-06 9:11 ` [linux-next][PATCH] " KOSAKI Motohiro
2009-02-06 14:55 ` [PATCH] " Ingo Molnar
2009-02-06 15:29 ` [linux-next][PATCH] " Jaswinder Singh Rajput
2009-02-06 15:33 ` Russell King - ARM Linux
2009-02-06 15:45 ` [PATCH] " Ingo Molnar
2009-02-06 15:49 ` Russell King - ARM Linux
2009-02-06 16:01 ` Ingo Molnar
2009-02-06 15:48 ` Jaswinder Singh Rajput
2009-02-06 15:55 ` [linux-next][PATCH] " Russell King - ARM Linux
2009-02-06 16:12 ` Ingo Molnar
2009-02-06 16:23 ` Russell King - ARM Linux
2009-02-06 16:33 ` [PATCH] " Ingo Molnar
2009-02-06 16:38 ` Russell King - ARM Linux
2009-02-06 17:14 ` [linux-next][PATCH] " Ingo Molnar
2009-02-06 17:22 ` Russell King - ARM Linux
2009-02-06 17:32 ` Sam Ravnborg
2009-02-06 17:41 ` Ingo Molnar
2009-02-06 18:53 ` [PATCH] " Luck, Tony
2009-02-06 13:42 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206164546.6291.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp$(echo .)fujitsu.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=chris@zankel$(echo .)net \
--cc=cooloney@kernel$(echo .)org \
--cc=dhowells@redhat$(echo .)com \
--cc=hskinnemoen@atmel$(echo .)com \
--cc=jaswinder@kernel$(echo .)org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=matthew@wil$(echo .)cx \
--cc=mingo@elte$(echo .)hu \
--cc=ralf@linux-mips$(echo .)org \
--cc=sam@ravnborg$(echo .)org \
--cc=tony.luck@intel$(echo .)com \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox