From: Ingo Molnar <mingo@elte•hu>
To: Cyrill Gorcunov <gorcunov@gmail•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Thomas Gleixner <tglx@linutronix•de>,
"H. Peter Anvin" <hpa@zytor•com>,
linux-next@vger•kernel.org
Subject: Re: linux-next: x86 tree build warning
Date: Fri, 6 Mar 2009 12:05:08 +0100 [thread overview]
Message-ID: <20090306110508.GE21168@elte.hu> (raw)
In-Reply-To: <aa79d98a0903052123i770bc198i425ac2389a8986fa@mail.gmail.com>
* Cyrill Gorcunov <gorcunov@gmail•com> wrote:
> On Fri, Mar 6, 2009 at 7:01 AM, Cyrill Gorcunov <gorcunov@gmail•com> wrote:
> > On 3/6/09, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> >> Hi all,
> >>
> >> Today's linux-next build (x86_64 allmodconfig) produced this warning:
> >>
> >> In file included from drivers/char/epca.c:49:
> >> drivers/char/digiFep1.h:7:1: warning: "GLOBAL" redefined
> >> In file included from include/linux/linkage.h:5,
> >> from include/linux/kernel.h:11,
> >> from arch/x86/include/asm/system.h:10,
> >> from arch/x86/include/asm/processor.h:17,
> >> from include/linux/prefetch.h:14,
> >> from include/linux/list.h:6,
> >> from include/linux/module.h:9,
> >> from drivers/char/epca.c:29:
> >> arch/x86/include/asm/linkage.h:55:1: warning: this is the location of the
> >> previous definition
> >>
> >> Probably introduced by commit 95695547a7db44b88a7ee36cf5df188de267e99e
> >> ("x86: asm linkage - introduce GLOBAL macro") from the x86 tree.
> >> --
> >> Cheers,
> >> Stephen Rothwell sfr@canb•auug.org.au
> >> http://www.canb.auug.org.au/~sfr/
> >>
> >
> > Thanks Stephen, i will take a look. Iirc the same macro used as well
> > in ia64 arch, weird.
> >
>
> I've just checked the sources -- it seems some definitions in
> arch/x86/include/asm/linkage.h should be guarded by
> __ASSEMBLY__ (ie -- __ALIGN, __ALIGN_STR and eventually
> GLOBAL). I'll make a patch today evening (can't get access to
> linux machine right now). Ingo?
sure, that's fine. It's not a fatal warning.
Ingo
prev parent reply other threads:[~2009-03-06 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 0:47 linux-next: x86 tree build warning Stephen Rothwell
2009-03-06 4:01 ` Cyrill Gorcunov
2009-03-06 5:23 ` Cyrill Gorcunov
2009-03-06 11:05 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090306110508.GE21168@elte.hu \
--to=mingo@elte$(echo .)hu \
--cc=gorcunov@gmail$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox