Subject: Re: linux-next: NCR_700_detect warnings

From: Greg KH <[email-masked]>
Date: Tue, 10 Mar 2009 21:07:30 -0700

On Wed, Mar 11, 2009 at 09:59:09AM +0800, Ming Lei wrote:
> 2009/3/11 Geert Uytterhoeven <[email-masked]>:
> > commit 76afea5b078d36ec080a75c29ff5a3fbc5774fee
> > Author: Ming Lei <[email-masked]>
> > Date:   Fri Feb 6 23:40:12 2009 +0800
> >
> >    platform driver: fix incorrect use of 'platform_bus_type' with 'struct devic
> >
> >    This patch fixes the bug reported in
> >        http://bugzilla.kernel.org/show_bug.cgi?id=11681.
> >
> >    "Lots of device drivers register a 'struct device_driver' with
> >    the '.bus' member set to '&platform_bus_type'. This is wrong,
> >    since the platform_bus functions expect the 'struct device_driver'
> >    to be wrapped up in a 'struct platform_driver' which provides
> >    some additional callbacks (like suspend_late, resume_early).
> >    The effect may be that platform_suspend_late() uses bogus data
> >    outside the device_driver struct as a pointer pointer to the
> >    device driver's suspend_late() function or other hard to
> >    reproduce failures."(Lothar Wassmann)
> >
> >    Signed-off-by: Ming Lei <[email-masked]>
> >    Acked-by: Henrique de Moraes Holschuh <[email-masked]>
> >    Acked-by: David Brownell <[email-masked]>
> >    Signed-off-by: Greg Kroah-Hartman <[email-masked]>
> >
> > This introduced the following warnings on m68k, as `dev' is now a
> > `struct platform_device *' instead of a `struct device *':
> >
> > | drivers/scsi/a4000t.c:64: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type
> > | drivers/scsi/mvme16x_scsi.c:67: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type
> > | drivers/scsi/bvme6000_scsi.c:61: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type
> >
> > I think the below is missing (untested on real hardware)?
> 
> Yes, you are correct. It is really missed.

Great, Geert, care to resend with a signed-off-by: so I can apply this?

thanks,

greg k-h