Subject: Re: linux-next: sh build failure

From: Mathieu Desnoyers <[email-masked]>
Date: Fri, 20 Mar 2009 14:24:13 -0400

* Stephen Rothwell ([email-masked]) wrote:
> Hi Paul,
> 
> Yesterday's linux-next build of sh allmodconfig failed like this:
> 
> kernel/built-in.o: In function `disable_all_kprobes':
> kernel/kprobes.c:1382: undefined reference to `text_mutex'
> kernel/built-in.o: In function `__unregister_kprobe_top':
> kernel/kprobes.c:773: undefined reference to `text_mutex'
> kernel/built-in.o: In function `register_kprobe':
> kernel/kprobes.c:724: undefined reference to `text_mutex'
> 
> Introduced by commit 4460fdad85becd569f11501ad5b91814814335ff ("tracing,
> Text Edit Lock - kprobes architecture independent support") from the
> tracing tree.  text_mutex is defined in mm/memory.c which is only built
> if CONFIG_MMU is defined, which is not true for sh allmodconfig.

Hrm, so we should move the text_mutex in a obj-y file. It's not clear to
me which of mm/Makefile would be the best choice :

obj-y                   := bootmem.o filemap.o mempool.o oom_kill.o fadvise.o \
                           maccess.o page_alloc.o page-writeback.o pdflush.o \
                           readahead.o swap.o truncate.o vmscan.o shmem.o \
                           prio_tree.o util.o mmzone.o vmstat.o backing-dev.o \
                           page_isolation.o mm_init.o $(mmu-y)

Or maybe we add a new file, or put this in kernel/*.c. Suggestions ?

Mathieu

> -- 
> Cheers,
> Stephen Rothwell                    [email-masked]
> http://www.canb.auug.org.au/~sfr/

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68