From: Heiko Carstens <heiko.carstens@de•ibm.com>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Jan Glauber <jang@linux•vnet.ibm.com>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Martin Schwidefsky <schwidefsky@de•ibm.com>
Subject: Re: linux-next: Tree for March 20 - crypto crash on s390
Date: Sat, 21 Mar 2009 11:56:29 +0100 [thread overview]
Message-ID: <20090321115629.6e911679@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20090321062605.GA14046@gondor.apana.org.au>
On Sat, 21 Mar 2009 14:26:05 +0800
Herbert Xu <herbert@gondor•apana.org.au> wrote:
> On Fri, Mar 20, 2009 at 01:59:12PM +0100, Heiko Carstens wrote:
> >
> > gets called with an shash_desc where
> >
> > bsize = crypto_shash_blocksize(desc->tfm);
> >
> > results in bsize with zero.
>
> Oops, this patch should fix it.
>
> commit b24c94a0d65282dc466339390472d7539e1706c2
> Author: Herbert Xu <herbert@gondor•apana.org.au>
> Date: Sat Mar 21 14:25:19 2009 +0800
>
> crypto: sha512-s390 - Add missing block size
>
> I missed the block size when converting sha512-s390 to shash.
>
> Reported-by: Heiko Carstens <heiko.carstens@de•ibm.com>
> Signed-off-by: Herbert Xu <herbert@gondor•apana.org.au>
>
> diff --git a/arch/s390/crypto/sha512_s390.c b/arch/s390/crypto/sha512_s390.c
> index 420acf4..37b4236 100644
> --- a/arch/s390/crypto/sha512_s390.c
> +++ b/arch/s390/crypto/sha512_s390.c
> @@ -84,6 +84,7 @@ static struct shash_alg sha384_alg = {
> .cra_driver_name= "sha384-s390",
> .cra_priority = CRYPT_S390_PRIORITY,
> .cra_flags = CRYPTO_ALG_TYPE_SHASH,
> + .cra_blocksize = SHA512_BLOCK_SIZE,
Yes, it does fix it. Thanks!
Tested-by: Heiko Carstens <heiko.carstens@de•ibm.com>
next prev parent reply other threads:[~2009-03-21 10:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 5:28 linux-next: Tree for March 20 Stephen Rothwell
2009-03-20 9:05 ` Next March 20 : drivers/md/dm-exception-store build break Sachin Sant
2009-03-20 9:09 ` linux-next: Tree for March 20 - timeriomem build break on s390 Heiko Carstens
2009-03-21 6:19 ` Herbert Xu
2009-03-21 10:38 ` Alexander Clouter
2009-03-20 9:14 ` linux-next: Tree for March 20 - dnet " Heiko Carstens
2009-03-20 11:06 ` [PATCH] dnet: DNET should depend on HAS_IOMEM Ilya Yanok
2009-03-21 23:58 ` David Miller
2009-03-20 12:59 ` linux-next: Tree for March 20 - crypto crash on s390 Heiko Carstens
2009-03-21 6:26 ` Herbert Xu
2009-03-21 10:56 ` Heiko Carstens [this message]
2009-03-21 13:13 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090321115629.6e911679@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de$(echo .)ibm.com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jang@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox