From: Subrata Modak <tosubrata@gmail•com>
To: Greg Kroah-Hartman <gregkh@suse•de>
Cc: Sachin Sant <sachinp@in•ibm.com>,
Subrata Modak <tosubrata@gmail•com>,
linux-next@vger•kernel.org,
Stephen Rothwell <sfr@canb•auug.org.au>, Greg KH <greg@kroah•com>,
LKML <linux-kernel@vger•kernel.org>
Subject: [PATCH] Re: Next March 25: staging/epl build break.
Date: Wed, 25 Mar 2009 19:37:13 +0530 [thread overview]
Message-ID: <20090325140713.4919.64147.sendpatchset@subratamodak.linux.ibm.com> (raw)
Hi Greg,
>Today's next x86 randconfig build failed with
>
>drivers/staging/epl/VirtualEthernetLinux.c: In function VEthAddInstance:
>drivers/staging/epl/VirtualEthernetLinux.c:302: error: struct net_device has no member named open
>drivers/staging/epl/VirtualEthernetLinux.c:303: error: struct net_device has no member named stop
>drivers/staging/epl/VirtualEthernetLinux.c:304: error: struct net_device has no member named get_stats
>drivers/staging/epl/VirtualEthernetLinux.c:305: error: struct net_device has no member named hard_start_xmit
>drivers/staging/epl/VirtualEthernetLinux.c:306: error: struct net_device has no member named tx_timeout
>
The above build problem reported by Sachin can be fixed with the
patch below. However, it still will leave with the following
warnings, which i think can be ignored:
drivers/staging/epl/VirtualEthernetLinux.c:164: warning: ‘VEthOpen’ defined but not used
drivers/staging/epl/VirtualEthernetLinux.c:183: warning: ‘VEthClose’ defined but not used
drivers/staging/epl/VirtualEthernetLinux.c:196: warning: ‘VEthXmit’ defined but not used
drivers/staging/epl/VirtualEthernetLinux.c:231: warning: ‘VEthGetStats’ defined but not used
drivers/staging/epl/VirtualEthernetLinux.c:238: warning: ‘VEthTimeout’ defined but not used
>.config attached.
>
>Thanks
>-Sachin
Signed-Off-By: Subrata Modak <subrata@linux•vnet.ibm.com>
---
--- a/linux-2.6.29/drivers/staging/epl/Kconfig 2009-03-24 04:42:14.000000000 +0530
+++ b/linux-2.6.29/drivers/staging/epl/Kconfig 2009-03-25 19:01:18.000000000 +0530
@@ -1,6 +1,7 @@
config EPL
tristate "openPOWERLINK protocol stack"
depends on NET && HIGH_RES_TIMERS && X86
+ depends on COMPAT_NET_DEV_OPS
default N
---help---
Enable support for the openPOWERLINK network protocol stack.
--- a/linux-2.6.29/drivers/staging/epl/VirtualEthernetLinux.c 2009-03-25 18:38:06.000000000 +0530
+++ b/linux-2.6.29/drivers/staging/epl/VirtualEthernetLinux.c 2009-03-25 19:03:16.000000000 +0530
@@ -299,11 +299,13 @@ tEplKernel VEthAddInstance(tEplDllkInitP
goto Exit;
}
+#ifdef CONFIG_COMPAT_NET_DEV_OPS
pVEthNetDevice_g->open = VEthOpen;
pVEthNetDevice_g->stop = VEthClose;
pVEthNetDevice_g->get_stats = VEthGetStats;
pVEthNetDevice_g->hard_start_xmit = VEthXmit;
pVEthNetDevice_g->tx_timeout = VEthTimeout;
+#endif
pVEthNetDevice_g->watchdog_timeo = EPL_VETH_TX_TIMEOUT;
pVEthNetDevice_g->destructor = free_netdev;
--
Regards--
Subrata
reply other threads:[~2009-03-25 14:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325140713.4919.64147.sendpatchset@subratamodak.linux.ibm.com \
--to=tosubrata@gmail$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sachinp@in$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox