Subject: Re: linux-next: pci tree build failure

From: Stephen Rothwell <[email-masked]>
Date: Wed, 25 Mar 2009 14:41:17 +1100

Hi Jesse,

On Tue, 24 Mar 2009 18:38:00 -0700 Jesse Barnes <[email-masked]> wrote:
>
> On Wed, 25 Mar 2009 12:21:21 +1100
> Stephen Rothwell <[email-masked]> wrote:
> 
> > On Mon, 23 Mar 2009 12:49:48 +1100 Stephen Rothwell
> > <[email-masked]> wrote:
> > >
> > > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> > > 
> > > arch/powerpc/kernel/msi.c: In function 'arch_msi_check_device':
> > > arch/powerpc/kernel/msi.c:23: error: 'PCI_CAP_ID_MSI' undeclared
> > > (first use in this function)
> > > 
> > > Caused by commit 1c8d7b0a562da06d3ebe83f01b1ed553205d1ae4 ("PCI
> > > MSI: Add support for multiple MSI").  PCI_CAP_ID_MSI is defined in
> > > linux/pci_regs.h which is included by linux/pci.h, but neither is
> > > included by arch/powerpc/kernel/msi.c.
> > > 
> > > I have used the version of the pci tree from next-20090320 for
> > > today.
> > 
> > This is still happening ...
> 
> Does this fix it?  Some header file changes must be to blame...

Yeah, that patch fixes it, but so does just reverting the commit above,
so I guess that powerpc file did not need any of the pci.h infrastructure
before.

Tested-by: Stephen Rothwell <[email-masked]>

-- 
Cheers,
Stephen Rothwell                    [email-masked]
http://www.canb.auug.org.au/~sfr/