From: David Miller <davem@davemloft•net>
To: randy.dunlap@oracle•com
Cc: shemminger@vyatta•com, sathyap@serverengines•com,
sfr@canb•auug.org.au, linux-next@vger•kernel.org,
netdev@vger•kernel.org, linux-drivers@serverengines•com
Subject: Re: [PATCH] benet: use do_div() for 64 bit divide
Date: Fri, 27 Mar 2009 00:26:39 -0700 (PDT) [thread overview]
Message-ID: <20090327.002639.94312978.davem@davemloft.net> (raw)
In-Reply-To: <49CBE123.5030204@oracle.com>
From: Randy Dunlap <randy.dunlap@oracle•com>
Date: Thu, 26 Mar 2009 13:10:11 -0700
> Stephen Hemminger wrote:
> > The benet driver is doing a 64 bit divide, which is not supported in Linux kernel
> > on 32 bit architectures. The correct way to do this is to use do_div().
> > Compile tested on i386 only.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
>
> Acked-by: Randy Dunlap <randy.dunlap@oracle•com> # and Tested-by: (built)
Applied, thanks everyone.
next prev parent reply other threads:[~2009-03-27 7:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 8:01 linux-next: Tree for March 26 Stephen Rothwell
2009-03-26 9:56 ` Next March 26: s390 allnoconfig build failure still exists Sachin Sant
2009-03-26 10:12 ` Heiko Carstens
2009-03-26 21:57 ` Stephen Rothwell
2009-03-26 15:46 ` linux-next: Tree for March 26 (benet) Randy Dunlap
2009-03-26 19:30 ` [PATCH] benet: use do_div() for 64 bit divide Stephen Hemminger
2009-03-26 20:10 ` Randy Dunlap
2009-03-27 7:26 ` David Miller [this message]
2009-03-26 21:44 ` [PATCH -next] exofs: fix printk format warnings Randy Dunlap
2009-03-30 8:14 ` Boaz Harrosh
2009-03-30 16:15 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327.002639.94312978.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=linux-drivers@serverengines$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sathyap@serverengines$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox