From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Alexey Dobriyan <adobriyan@gmail•com>
Cc: linux-next@vger•kernel.org,
"Eric W. Biederman" <ebiederm@xmission•com>,
Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>,
Al Viro <viro@zeniv•linux.org.uk>,
Andrew Morton <akpm@linux-foundation•org>
Subject: linux-next: proc tree build failure
Date: Mon, 30 Mar 2009 17:43:53 +1100 [thread overview]
Message-ID: <20090330174353.14a3f3d4.sfr@canb.auug.org.au> (raw)
Hi Alexey,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
fs/proc/proc_net.c: In function 'proc_net_get_sb':
fs/proc/proc_net.c:296: error: void value not ignored as it ought to be
Caused by commit 39bc389a04412aa199d8abec6582be33d57d1344 ("proc 3/6:
make /proc/net it's own filesystem") interacting with commit
a3ec947c85ec339884b30ef6a08133e9311fdae1 ("vfs: simple_set_mnt() should
return void") from Linus' tree.
I applied the following patch and can carry it for a while.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 30 Mar 2009 17:41:54 +1100
Subject: [PATCH] proc: update proc_net.c for simple_set_mnt API change
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
fs/proc/proc_net.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c
index 32dd84f..1e31e5d 100644
--- a/fs/proc/proc_net.c
+++ b/fs/proc/proc_net.c
@@ -293,7 +293,8 @@ static int proc_net_get_sb(struct file_system_type *fs_type,
sb->s_flags |= MS_ACTIVE;
}
- return simple_set_mnt(mnt, sb);
+ simple_set_mnt(mnt, sb);
+ return 0;
}
static struct file_system_type proc_net_fs_type = {
--
1.6.2.1
next reply other threads:[~2009-03-30 6:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 6:43 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-01-23 6:15 linux-next: proc tree build failure Stephen Rothwell
2009-01-23 7:09 ` Cyrill Gorcunov
2009-01-23 18:48 ` Alexey Dobriyan
2009-01-23 19:26 ` Cyrill Gorcunov
2009-01-23 19:41 ` Cyrill Gorcunov
2009-01-23 20:26 ` Cyrill Gorcunov
2008-11-24 7:15 Stephen Rothwell
2008-11-28 8:05 ` Alexey Dobriyan
2008-11-28 9:00 ` David Miller
2008-11-28 10:25 ` David Miller
2008-11-20 6:24 Stephen Rothwell
2008-11-20 8:43 ` Eric W. Biederman
2008-11-10 5:29 Stephen Rothwell
2008-11-10 5:53 ` Alexey Dobriyan
2008-11-10 7:36 ` Ingo Molnar
2008-10-21 7:21 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090330174353.14a3f3d4.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=adobriyan@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=ebiederm@xmission$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox