From: Heiko Carstens <heiko.carstens@de•ibm.com>
To: Ingo Molnar <mingo@elte•hu>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Linus <torvalds@linux-foundation•org>,
linux-next@vger•kernel.org,
Frederic Weisbecker <fweisbec@gmail•com>,
LKML <linux-kernel@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] lockdep: warn about lockdep disabling after kernel taint, fix
Date: Tue, 14 Apr 2009 11:23:03 +0200 [thread overview]
Message-ID: <20090414112303.22f7b2ac@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20090414091538.GI27003@elte.hu>
On Tue, 14 Apr 2009 11:15:38 +0200
Ingo Molnar <mingo@elte•hu> wrote:
> Subject: [PATCH] lockdep: warn about lockdep disabling after kernel taint, fix
>
> Impact: build fix
>
> Stephen Rothwell reported that the Sparc build broke:
>
> In file included from kernel/panic.c:12:
> include/linux/debug_locks.h: In function '__debug_locks_off':
> include/linux/debug_locks.h:15: error: implicit declaration of function 'xchg'
>
> due to:
>
> 9eeba61: lockdep: warn about lockdep disabling after kernel taint
>
> There is some inconsistency between architectures about where exactly
> xchg() is defined. Most have it in system.h but also in atomic.h (which
> is arguably the more logical point for it). Some, such as Sparc only
> have it in asm/system.h and not available via asm/atomic.h.
>
> Use the widest set of headers in debug_locks.h and also include asm/system.h.
>
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> Acked-by: Frederic Weisbecker <fweisbec@gmail•com>
> Signed-off-by: Ingo Molnar <mingo@elte•hu>
> ---
> include/linux/debug_locks.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
> index 493dedb..29b3ce3 100644
> --- a/include/linux/debug_locks.h
> +++ b/include/linux/debug_locks.h
> @@ -3,6 +3,7 @@
>
> #include <linux/kernel.h>
> #include <asm/atomic.h>
> +#include <asm/system.h>
Ah, ok. Please ignore my other mail from a few seconds ago ;)
This fixes the s390 build break. Thanks!
next prev parent reply other threads:[~2009-04-14 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 4:43 linux-next: origin tree build failure Stephen Rothwell
2009-04-14 8:57 ` David Miller
2009-04-14 9:20 ` Heiko Carstens
2009-04-14 9:08 ` David Miller
2009-04-14 10:26 ` Stephen Rothwell
2009-04-14 9:15 ` [PATCH] lockdep: warn about lockdep disabling after kernel taint, fix Ingo Molnar
2009-04-14 9:23 ` Heiko Carstens [this message]
2009-04-14 10:29 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090414112303.22f7b2ac@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de$(echo .)ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=fweisbec@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox