From: Heiko Carstens <heiko.carstens@de•ibm.com>
To: Sachin Sant <sachinp@in•ibm.com>
Cc: "Ingo Molnar" <mingo@elte•hu>,
"Steven Rostedt" <rostedt@goodmis•org>,
"Frédéric Weisbecker" <fweisbec@gmail•com>,
linux-s390@vger•kernel.org, linux-next@vger•kernel.org,
LKML <linux-kernel@vger•kernel.org>
Subject: Re: Next April 24: [S390] allmodconfig build failure (trace/events)
Date: Wed, 29 Apr 2009 13:51:39 +0200 [thread overview]
Message-ID: <20090429135139.5fac79b8@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <49F8232B.4090007@in.ibm.com>
On Wed, 29 Apr 2009 15:21:39 +0530
Sachin Sant <sachinp@in•ibm.com> wrote:
> Heiko Carstens wrote:
> > On Fri, 24 Apr 2009 09:25:33 +0200
> > Ingo Molnar <mingo@elte•hu> wrote:
> >> * Sachin Sant <sachinp@in•ibm.com> wrote:
> >>> Today's next tree build(s390 allmodconfig) failed with
> >>>
> >>> kernel/built-in.o: In function `trace_softirq_entry'
> >>> include/trace/events/irq.h:42: undefined reference to
> >>> `'
> >>> include/trace/events/irq.h:42: undefined reference to
> >>> `__tracepoint_softirq_entry'
> >>> kernel/built-in.o: In function `trace_softirq_exit':
> >>> include/trace/events/irq.h:48: undefined reference to
> >>> `__tracepoint_softirq_exit'
> >>> include/trace/events/irq.h:48: undefined reference to
> >>> `__tracepoint_softirq_exit'
> >>>
> >> Hm, that's weird - s390 does not build kernel/softirq.o? Hm, it does
> >> - softirq.o is an obj-y object.
> >
> > s390 does build kernel/softirq.o. However it's anything but obvious to
> > me how the tracepoint infrastructure works. Too many #ifdefs, #define's
> > and #undefine's...
> >
> > I would expect that struct __tracepoint_softirq_entry somehow gets
> > defined via one of the TRACE_FORMAT macros, no?
> Today's next tree also has this failure. Any solution for this problem ?
Ingo, could you pick up the patch below please?
Subject: [PATCH] tracing: fix compile error
From: Heiko Carstens <heiko.carstens@de•ibm.com>
"tracing: create automated trace defines" causes this compile error on s390:
kernel/built-in.o: In function `__do_softirq':
(.text+0x1c680): undefined reference to `__tracepoint_softirq_entry'
This happens because the definitions of the softirq tracepoints were moved
from kernel/softirq.c to kernel/irq/handle.c. Since s390 doesn't support
generic hardirqs handle.c doesn't get compiled and the definitions are
missing.
So move the tracepoints to softirq.c again.
Reported-by: Sachin Sant <sachinp@in•ibm.com>
Cc: Steven Rostedt <rostedt@goodmis•org>
Signed-off-by: Heiko Carstens <heiko.carstens@de•ibm.com>
---
kernel/irq/handle.c | 2 --
kernel/softirq.c | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
Index: linux-next/kernel/irq/handle.c
===================================================================
--- linux-next.orig/kernel/irq/handle.c
+++ linux-next/kernel/irq/handle.c
@@ -18,8 +18,6 @@
#include <linux/rculist.h>
#include <linux/hash.h>
#include <linux/bootmem.h>
-
-#define CREATE_TRACE_POINTS
#include <trace/events/irq.h>
#include "internals.h"
Index: linux-next/kernel/softirq.c
===================================================================
--- linux-next.orig/kernel/softirq.c
+++ linux-next/kernel/softirq.c
@@ -24,6 +24,8 @@
#include <linux/ftrace.h>
#include <linux/smp.h>
#include <linux/tick.h>
+
+#define CREATE_TRACE_POINTS
#include <trace/events/irq.h>
#include <asm/irq.h>
next prev parent reply other threads:[~2009-04-29 11:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-24 5:04 linux-next: Tree for April 24 Stephen Rothwell
2009-04-24 6:55 ` Next April 24 : BUG: lock held at task exit time! Sachin Sant
2009-04-24 7:55 ` Stephen Rothwell
2009-04-24 11:55 ` Hugh Dickins
2009-04-24 14:04 ` Al Viro
2009-04-24 14:11 ` Stephen Rothwell
2009-04-24 7:12 ` Next April 24: [S390] allmodconfig build failure (trace/events) Sachin Sant
2009-04-24 7:25 ` Ingo Molnar
2009-04-24 8:41 ` Heiko Carstens
2009-04-29 9:51 ` Sachin Sant
2009-04-29 11:51 ` Heiko Carstens [this message]
2009-04-29 12:04 ` Ingo Molnar
2009-04-29 12:09 ` Steven Rostedt
[not found] ` <20090424150456.ff35e4ea.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2009-04-24 17:56 ` linux-next: Tree for April 24 (p54 build error) Randy Dunlap
2009-04-24 20:47 ` linux-next: Tree for April 24 (p54 build error) (and pull request: wireless-next-2.6 2009-04-24) Christian Lamparter
[not found] ` <200904242247.15042.chunkeey-S0/GAf8tV78@public.gmane.org>
2009-04-30 18:30 ` John W. Linville
2009-04-26 13:20 ` linux-next: Tree for April 24 Benny Halevy
2009-04-27 4:21 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090429135139.5fac79b8@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de$(echo .)ibm.com \
--cc=fweisbec@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=rostedt@goodmis$(echo .)org \
--cc=sachinp@in$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox