On Mon, May 25 2009 at 1:54am -0400, Stephen Rothwell wrote: > Hi Martin, > > On Mon, 25 May 2009 01:38:26 -0400 "Martin K. Petersen" wrote: > > > > The accessor function patch in my patch series was explicitly put in > > place to enable changing the API without affecting users. And we've > > tried to be careful about staging these patches in the right order > > throughout all the involved trees. > > What you really need is to have the patches that introduce the accessors > in a tree common to all the possible users of them. In practise this > often means Linus' tree - in which case the patches should introduce noop > versions of the accessors. If that is possible, Linus is quite happy to > take those patches after which all the other users can take the > conversions into their own tree and everyone is happy. :-) > > Currently the patches that introduce the accessors only exist in the > block tree ... I've refreshed the DM linux-next patches that were off Martin's radar; they are available here (and are also attached): http://people.redhat.com/msnitzer/patches/dm-topology/dm-table-ensure-targets-are-aligned-to-logical_block_size.patch http://people.redhat.com/msnitzer/patches/dm-topology/dm-table-validate-device-logical_block_size.patch These updated patches still seem useful (as negative checks independent of the topology code). There is more work that is needed in DM and LVM2 userspace in order to properly support and utilize the new topology infrastructure. So I'm also taking a much closer look at the needed changes now and should have it sorted out in the coming days. Mike