From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Matthew Garrett <mjg59@srcf•ucam.org>
Cc: Johannes Berg <johannes@sipsolutions•net>,
"John W. Linville" <linville@tuxdriver•com>,
linux-next@vger•kernel.org, Len Brown <lenb@kernel•org>
Subject: Re: linux-next: wireless tree build failure
Date: Wed, 3 Jun 2009 12:52:02 +1000 [thread overview]
Message-ID: <20090603125202.d507e59f.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20090422133601.GA25039@srcf.ucam.org>
[-- Attachment #1: Type: text/plain, Size: 3335 bytes --]
Hi all,
On Wed, 22 Apr 2009 14:36:01 +0100 Matthew Garrett <mjg59@srcf•ucam.org> wrote:
>
> On Wed, Apr 22, 2009 at 03:33:11PM +0200, Johannes Berg wrote:
> > But that's not the interesting part -- the thing is the rfkill rewrite.
> > I don't know how to handle that w/o breaking all users. I had hoped to
> > finish this very soon to be ready early in .31, but I'm still waiting
> > for Thinkpad and Toshiba conversions (and I forgot who wanted to look at
> > Toshiba), but if new users are being added in other trees then that's a
> > problem.
>
> oqo-wmi can be ignored for the moment - Len, can you drop it from your
> tree for now? I'll clean that bit up as well.
So the rfkill rewrite has now hit the wireless tree, so today's build
(x86_64_allmodconfig) failure looks like this:
drivers/platform/x86/oqo-wmi.c:716: warning: 'enum rfkill_state' declared inside parameter list
drivers/platform/x86/oqo-wmi.c:716: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/platform/x86/oqo-wmi.c: In function 'oqo_rfkill_get':
drivers/platform/x86/oqo-wmi.c:727: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:727: error: 'RFKILL_STATE_SOFT_BLOCKED' undeclared (first use in this function)
drivers/platform/x86/oqo-wmi.c:729: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:729: error: 'RFKILL_STATE_UNBLOCKED' undeclared (first use in this function)
drivers/platform/x86/oqo-wmi.c: At top level:
drivers/platform/x86/oqo-wmi.c:734: warning: 'enum rfkill_state' declared inside parameter list
drivers/platform/x86/oqo-wmi.c:734: error: parameter 2 ('state') has incomplete type
drivers/platform/x86/oqo-wmi.c: In function 'oqo_rfkill_toggle':
drivers/platform/x86/oqo-wmi.c:740: error: 'RFKILL_STATE_UNBLOCKED' undeclared (first use in this function)
drivers/platform/x86/oqo-wmi.c: In function 'oqo_rfkill_init':
drivers/platform/x86/oqo-wmi.c:752: error: implicit declaration of function 'rfkill_allocate'
drivers/platform/x86/oqo-wmi.c:752: warning: assignment makes pointer from integer without a cast
drivers/platform/x86/oqo-wmi.c:759: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:761: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:761: error: 'RFKILL_STATE_SOFT_BLOCKED' undeclared (first use in this function)
drivers/platform/x86/oqo-wmi.c:763: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:763: error: 'RFKILL_STATE_UNBLOCKED' undeclared (first use in this function)
drivers/platform/x86/oqo-wmi.c:765: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:766: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:767: error: dereferencing pointer to incomplete type
drivers/platform/x86/oqo-wmi.c:772: error: implicit declaration of function 'rfkill_free'
So I have reverted commit 9c82cd255907ad639bed4ffc8fcaf1bd59badb50
("platform/x86: Add oqo-wmi driver for model 2 OQO backlight and rfkill
control") and commit 94c4b5977f33894cc316edf07c5cb72b5d193628 ("oqo:
dev_set_name()") that depend son it.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-06-03 2:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 1:57 linux-next: wireless tree build failure Stephen Rothwell
2009-04-22 8:59 ` Johannes Berg
2009-04-22 13:03 ` Stephen Rothwell
2009-04-22 13:06 ` John W. Linville
2009-04-22 13:33 ` Johannes Berg
2009-04-22 13:36 ` Matthew Garrett
2009-06-03 2:52 ` Stephen Rothwell [this message]
2009-06-15 12:21 ` Stephen Rothwell
2009-04-22 13:11 ` Johannes Berg
2009-04-28 3:28 ` Stephen Rothwell
2009-04-28 12:50 ` John W. Linville
-- strict thread matches above, loose matches on Subject: below --
2009-11-09 8:08 Stephen Rothwell
2009-11-09 13:37 ` Bartlomiej Zolnierkiewicz
[not found] <20090505115455.0b147aeb.sfr@canb.auug.org.au>
2009-05-05 2:55 ` John W. Linville
2009-03-23 4:39 Stephen Rothwell
2009-03-23 4:53 ` David Miller
2009-03-23 5:01 ` Yang Hongyang
2009-03-23 4:55 ` David Miller
2009-03-23 5:06 ` Yang Hongyang
2009-03-23 5:48 ` Stephen Rothwell
2009-03-23 7:59 ` David Miller
2009-03-23 8:10 ` Stephen Rothwell
2009-02-27 2:44 Stephen Rothwell
2009-02-12 8:35 Stephen Rothwell
2009-02-12 16:16 ` John W. Linville
2009-02-12 22:07 ` Stephen Rothwell
2009-02-13 18:24 ` Dave
2009-02-13 18:24 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603125202.d507e59f.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=johannes@sipsolutions$(echo .)net \
--cc=lenb@kernel$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=mjg59@srcf$(echo .)ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox