From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Christoph Hellwig <hch@infradead•org>
Cc: LKML <linux-kernel@vger•kernel.org>,
linux-next@vger•kernel.org, Theodore Ts'o <tytso@mit•edu>,
Al Viro <viro@zeniv•linux.org.uk>,
linux-fsdevel@vger•kernel.org
Subject: Re: linux-next: next-20090609 hangs in early user mode
Date: Wed, 10 Jun 2009 18:44:55 +1000 [thread overview]
Message-ID: <20090610184455.c06375d2.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20090610083139.GA25538@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
Hi Christoph,
On Wed, 10 Jun 2009 04:31:39 -0400 Christoph Hellwig <hch@infradead•org> wrote:
>
> On Wed, Jun 10, 2009 at 06:00:58PM +1000, Stephen Rothwell wrote:
> > The machines are PowerPC64 (so big endian). It looks to me like we use
> > bitops on i_state - don't our bitops only apply to unsigned longs?
>
> Yes, bitops need unsigned long. And on most plaforms should give you
> warnings when using them on the wrong type.
In this case the "word" is being passed through wait_on_bit which takes a
"void *", so we lose the type information.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-06-10 8:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 8:00 linux-next: next-20090609 hangs in early user mode Stephen Rothwell
2009-06-10 8:31 ` Christoph Hellwig
2009-06-10 8:44 ` Stephen Rothwell [this message]
2009-06-10 8:46 ` Stephen Rothwell
2009-06-10 13:00 ` Al Viro
2009-06-10 13:07 ` Stephen Rothwell
2009-06-10 13:19 ` Theodore Tso
2009-06-10 15:08 ` Al Viro
2009-06-10 16:09 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610184455.c06375d2.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=hch@infradead$(echo .)org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=tytso@mit$(echo .)edu \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox