From: Nick Piggin <npiggin@suse•de>
To: Heiko Carstens <heiko.carstens@de•ibm.com>
Cc: Sachin Sant <sachinp@in•ibm.com>,
Pekka Enberg <penberg@cs•helsinki.fi>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, linux-s390@vger•kernel.org
Subject: Re: Next June 29: Boot failure with SLQB on s390
Date: Tue, 30 Jun 2009 12:29:58 +0200 [thread overview]
Message-ID: <20090630102958.GF1114@wotan.suse.de> (raw)
In-Reply-To: <20090630100929.GA2559@osiris.boeblingen.de.ibm.com>
On Tue, Jun 30, 2009 at 12:09:29PM +0200, Heiko Carstens wrote:
> On Tue, Jun 30, 2009 at 11:06:31AM +0200, Nick Piggin wrote:
> > On Mon, Jun 29, 2009 at 04:12:34PM +0200, Heiko Carstens wrote:
> > > slqb returns ZERO_SIZE_PTR instead of NULL for large size requests it cannot
> > > handle.
> > > The patch below would fix it. But I think its too ugly. So I leave it up to
> > > Nick to come up with a real and nice patch ;)
> >
> > Could you try this patch and see if it helps? (it fixes a number
> > of simple corner cases here, *blush*)
>
> Yes, it does work now. Thanks!
Thanks. Pekka, can you please merge this with
Signed-off-by: Nick Piggin <npiggin@suse•de>
>
> > SLQB: fix allocation size checking
> >
> > SLQB would return ZERO_SIZE_PTR rather than NULL if the requested size is too
> > large. Debugged by Heiko Carstens. Fix this by checking size edge cases up
> > front rather than in the slab index calculation.
> >
> > Additionally, if the size parameter was non-constant and too large, then
> > the checks may not have been performed at all which could cause corruption.
> >
> > Next, ARCH_KMALLOC_MINALIGN may not be obeyed if size is non-constant. So
> > test for KMALLOC_MIN_SIZE in that case.
> >
> > Finally, if KMALLOC_SHIFT_SLQB_HIGH is larger than 2MB, then kmalloc_index
> > could silently run off the end of its precomputed table and return a -1
> > index into the kmalloc slab array, which could result in corruption. Extend
> > this to allow up to 32MB (to match SLAB), and add a compile-time error in
> > the case that the table is exceeded (also like SLAB).
next prev parent reply other threads:[~2009-06-30 10:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 6:48 linux-next: Tree for June 29 Stephen Rothwell
2009-06-29 9:44 ` Next June 29: Boot failure with SLQB on s390 Sachin Sant
2009-06-29 10:31 ` Heiko Carstens
2009-06-29 10:39 ` Nick Piggin
2009-06-29 11:50 ` Heiko Carstens
2009-06-29 11:58 ` Nick Piggin
2009-06-29 13:09 ` Heiko Carstens
2009-06-29 14:12 ` Heiko Carstens
2009-06-30 7:34 ` Nick Piggin
2009-06-30 9:06 ` Nick Piggin
2009-06-30 9:20 ` Pekka Enberg
2009-06-30 9:27 ` Nick Piggin
2009-06-30 9:30 ` Pekka Enberg
2009-06-30 10:09 ` Heiko Carstens
2009-06-30 10:29 ` Nick Piggin [this message]
2009-06-30 10:57 ` Pekka Enberg
2009-06-30 5:33 ` Sachin Sant
2009-06-30 8:34 ` Nick Piggin
2009-06-30 10:56 ` Sachin Sant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630102958.GF1114@wotan.suse.de \
--to=npiggin@suse$(echo .)de \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=penberg@cs$(echo .)helsinki.fi \
--cc=sachinp@in$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox