Subject: Re: linux-next: Tree for July 23

From: Kamalesh Babulal <[email-masked]>
Date: Thu, 23 Jul 2009 21:55:01 +0530

Hi Greg,

	next-20090723 randconfig build breaks at

drivers/staging/android/lowmemorykiller.c: In function '__check_cost':
drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared (first use in this function)
drivers/staging/android/lowmemorykiller.c:60: error: (Each undeclared identifier is reported only once
drivers/staging/android/lowmemorykiller.c:60: error: for each function it appears in.)
drivers/staging/android/lowmemorykiller.c: At top level:
drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared here (not in a function)
drivers/staging/android/lowmemorykiller.c:60: warning: type defaults to 'int' in declaration of 'type name'
make[3]: *** [drivers/staging/android/lowmemorykiller.o] Error 1
make[2]: *** [drivers/staging/android] Error 2
make[1]: *** [drivers/staging] Error 2

I have tested the patch for the build failure only.

Signed-off-by: Kamalesh Babulal <[email-masked]>
--
--- linux/drivers/staging/android/lowmemorykiller.c	2009-07-23 12:15:59.000000000 -0400
+++ linux/drivers/staging/android/~lowmemorykiller.c	2009-07-23 12:17:46.000000000 -0400
@@ -57,13 +57,6 @@ static int lowmem_minfree_size = 4;
 			printk(x);			\
 	} while (0)
 
-module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
-module_param_array_named(adj, lowmem_adj, int, &lowmem_adj_size,
-			 S_IRUGO | S_IWUSR);
-module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
-			 S_IRUGO | S_IWUSR);
-module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
-
 static int lowmem_shrink(int nr_to_scan, gfp_t gfp_mask)
 {
 	struct task_struct *p;
@@ -155,6 +148,13 @@ static struct shrinker lowmem_shrinker =
 	.seeks = DEFAULT_SEEKS * 16
 };
 
+module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
+module_param_array_named(adj, lowmem_adj, int, &lowmem_adj_size,
+			 S_IRUGO | S_IWUSR);
+module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
+			 S_IRUGO | S_IWUSR);
+module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
+
 static int __init lowmem_init(void)
 {
 	register_shrinker(&lowmem_shrinker);

					Kamalesh