From: Ingo Molnar <mingo@elte•hu>
To: Borislav Petkov <borislav.petkov@amd•com>,
Andreas Herrmann <andreas.herrmann3@amd•com>
Cc: "H. Peter Anvin" <hpa@zytor•com>,
Thomas Gleixner <tglx@linutronix•de>,
Sachin Sant <sachinp@in•ibm.com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Ingo Molnar <mingo@redhat•com>
Subject: Re: Boot failure on x86_64 (OOPS set_cpu_sibling_map() )
Date: Mon, 3 Aug 2009 14:07:39 +0200 [thread overview]
Message-ID: <20090803120739.GA29156@elte.hu> (raw)
In-Reply-To: <20090803101401.GA14442@aftab>
* Borislav Petkov <borislav.petkov@amd•com> wrote:
> Hi Ingo,
>
> On Mon, Aug 03, 2009 at 11:31:44AM +0200, Ingo Molnar wrote:
> > Borislav, this patch:
> >
> > From 4581c6313c16a38ffcef8bccd6ffbe9598d585b0 Mon Sep 17 00:00:00 2001
> > From: Andreas Herrmann <andreas.herrmann3@amd•com>
> > Date: Fri, 24 Jul 2009 10:21:06 +0200
> > Subject: [PATCH] x86: provide CPU topology information for multi-node processors
> >
> > arch/x86/include/asm/processor.h | 2 ++
> > arch/x86/include/asm/smp.h | 6 ++++++
> > arch/x86/include/asm/topology.h | 2 ++
> > arch/x86/kernel/cpu/common.c | 2 ++
> > arch/x86/kernel/cpu/proc.c | 1 +
> > arch/x86/kernel/smpboot.c | 20 ++++++++++++++++----
> > 6 files changed, 29 insertions(+), 4 deletions(-)
> >
> > has absolutely _ZERO_ place in the EDAC tree. It was submitted to
> > the x86 tree and was under discussion - i requested changes to it so
> > this current form has my NAK.
>
> I know that, I'm following the discussion. I needed the
> functionality in EDAC and that's why I added them _temporarily_ to
> the mix so that the whole series (esp. the MCE bits) can see some
> testing. Which obviously caught some issues :).
>
> But I'm very well aware that the patches are not final and they
> will go through x86 when done. This is what I told Stephen when
> upping them for linux-next.
Next time please tell the x86 maintainers too ;-)
The thing that was blocking this commit is really the insufficient
sched-domains integration of said NUMA bits. I think the NUMA bits
look good and if the EDAC tree makes use of it we can merge it in
.32.
Mind preparing a separate branch for it (.31-rc5 based) and send me
a pull request so that we can share the commit between the EDAC tree
and the x86 tree?
Thanks,
Ingo
next prev parent reply other threads:[~2009-08-03 12:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 8:21 linux-next: Tree for July 30 Stephen Rothwell
2009-07-30 11:25 ` Boot failure on x86_64 (OOPS set_cpu_sibling_map() ) Sachin Sant
2009-07-30 13:56 ` Borislav Petkov
2009-07-31 10:41 ` Sachin Sant
2009-08-03 9:31 ` Ingo Molnar
2009-08-03 10:14 ` Borislav Petkov
2009-08-03 12:07 ` Ingo Molnar [this message]
2009-08-03 12:50 ` Borislav Petkov
2009-08-04 13:50 ` Ingo Molnar
2009-08-04 14:31 ` Borislav Petkov
2009-08-04 14:47 ` Ingo Molnar
2009-08-04 15:00 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803120739.GA29156@elte.hu \
--to=mingo@elte$(echo .)hu \
--cc=andreas.herrmann3@amd$(echo .)com \
--cc=borislav.petkov@amd$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@redhat$(echo .)com \
--cc=sachinp@in$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox