Subject: Re: linux-next: cpufreq tree build failure

From: Thomas Renninger <[email-masked]>
Date: Tue, 4 Aug 2009 01:22:14 +0200

On Monday 03 August 2009 04:28:19 am Stephen Rothwell wrote:
> Hi Dave,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> ERROR: "cpufreq_global_kobject" [drivers/cpufreq/cpufreq_ondemand.ko]
> undefined!
>
> Caused by commit 35b104d88338e5eddb36c670fea4752f6c10c82f ("[CPUFREQ]
> ondemand - Use global sysfs dir for tuning settings").  Presumably
> cpufreq_global_kobject needs an EXPORT_SYMBOL.

Yep, that's it. Below is a fix.

Thanks a lot,

     Thomas

---------
CPUFREQ: fix build if ondemand is compiled as module

struct kobject *cpufreq_global_kobject must be exported

CC: Stephen Rothwell <[email-masked]>
CC: Dave Jones <[email-masked]>
Signed-off-by: Thomas Renninger <[email-masked]>

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 9bb2c4a..9d9251f 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -778,6 +778,7 @@ define_one_global_ro(scaling_driver);
 define_one_global_rw(scaling_governor);
 
 struct kobject *cpufreq_global_kobject;
+EXPORT_SYMBOL(cpufreq_global_kobject);
 
 #define to_policy(k) container_of(k, struct cpufreq_policy, kobj)
 #define to_attr(a) container_of(a, struct freq_attr, attr)