From: Randy Dunlap <randy.dunlap@oracle•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Felipe Balbi <felipe.balbi@nokia•com>,
gregkh@suse•de
Cc: linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
akpm <akpm@linux-foundation•org>
Subject: [PATCH -next] usb/otg: fix twl4030-usb build
Date: Tue, 11 Aug 2009 11:31:31 -0700 [thread overview]
Message-ID: <20090811113131.44db4177.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20090811183434.28afaf80.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle•com>
subsys_initcall_sync() is only defined for built-in code, not for
loadable modules, so this driver build fails when built as a module.
However, the _sync() forms of the initcalls are not implemented,
so this should not be used -- just use the non-sync form of it.
drivers/usb/otg/twl4030-usb.c:777: warning: data definition has no type or storage class
drivers/usb/otg/twl4030-usb.c:777: warning: type defaults to 'int' in declaration of 'subsys_initcall_sync'
drivers/usb/otg/twl4030-usb.c:777: warning: parameter names (without types) in function declaration
Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Felipe Balbi <felipe.balbi@nokia•com>
---
drivers/usb/otg/twl4030-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20090811.orig/drivers/usb/otg/twl4030-usb.c
+++ linux-next-20090811/drivers/usb/otg/twl4030-usb.c
@@ -774,7 +774,7 @@ static int __init twl4030_usb_init(void)
{
return platform_driver_register(&twl4030_usb_driver);
}
-subsys_initcall_sync(twl4030_usb_init);
+subsys_initcall(twl4030_usb_init);
static void __exit twl4030_usb_exit(void)
{
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
prev parent reply other threads:[~2009-08-11 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 8:34 linux-next: Tree for August 11 Stephen Rothwell
2009-08-11 18:31 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090811113131.44db4177.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=felipe.balbi@nokia$(echo .)com \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox