Subject: Re: [PATCH -next] trace_skb: fix build when CONFIG_NET is not enabled

From: Ingo Molnar <[email-masked]>
Date: Mon, 17 Aug 2009 23:58:08 +0200

* Randy Dunlap <[email-masked]> wrote:

> From: Randy Dunlap <[email-masked]>
> 
> Fix trace_skb_sources build when CONFIG_NET is not enabled:
> 
> kernel/built-in.o: In function `probe_skb_dequeue':
> trace_skb_sources.c:(.text+0xd9152): undefined reference to `init_net'
> trace_skb_sources.c:(.text+0xd9188): undefined reference to `dev_get_by_index'
> 
> Signed-off-by: Randy Dunlap <[email-masked]>
> Cc: Neil Horman <[email-masked]>
> ---
>  kernel/trace/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20090817.orig/kernel/trace/Kconfig
> +++ linux-next-20090817/kernel/trace/Kconfig
> @@ -236,6 +236,7 @@ config BOOT_TRACER
>  
>  config SKB_SOURCES_TRACER
>  	bool "Trace skb source information"
> +	depends on NET
>  	select GENERIC_TRACER
>  	help
>  	   This tracer helps developers/sysadmins correlate skb allocation and

Hm, there's nothing like this in the tracing tree.

Could we please move kernel/trace/* commits to the tracing tree, so 
that it gets adequate testing and review, etc?

	Ingo