From: Martin Schwidefsky <schwidefsky@de•ibm.com>
To: Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
heiko.carstens@de•ibm.com, linux-s390@vger•kernel.org,
adobriyan@gmail•com
Subject: Re: linux-next: 20090925 - build breaks with !CONFIG_AIO
Date: Sat, 26 Sep 2009 13:37:02 +0200 [thread overview]
Message-ID: <20090926133702.44f315f7@mschwide.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20090925131958.GC6831@linux.vnet.ibm.com>
On Fri, 25 Sep 2009 18:49:58 +0530
Kamalesh Babulal <kamalesh@linux•vnet.ibm.com> wrote:
> Hi Stephen,
>
> next-20090925 randconfig build breaks on s390x, with CONFIG_AIO=n.
>
> arch/s390/mm/pgtable.c: In function 's390_enable_sie':
> arch/s390/mm/pgtable.c:282: error: 'struct mm_struct' has no member named 'ioctx_list'
> arch/s390/mm/pgtable.c:298: error: 'struct mm_struct' has no member named 'ioctx_list'
> make[1]: *** [arch/s390/mm/pgtable.o] Error 1
>
> Reverting the below commit helps
>
> commit 858f09930b32c11b40fd0c5c467982ba09b10894
> Author: Alexey Dobriyan <adobriyan@gmail•com>
> Date: Wed Sep 23 15:57:32 2009 -0700
>
> aio: ifdef fields in mm_struct
>
> ->ioctx_lock and ->ioctx_list are used only under CONFIG_AIO.
That should be fixed in the s390 pgtable.c code:
--
Subject: [PATCH] fix build breakage with CONFIG_AIO=n
From: Martin Schwidefsky <schwidefsky@de•ibm.com>
next-20090925 randconfig build breaks on s390x, with CONFIG_AIO=n.
arch/s390/mm/pgtable.c: In function 's390_enable_sie':
arch/s390/mm/pgtable.c:282: error: 'struct mm_struct' has no member named 'ioctx_list'
arch/s390/mm/pgtable.c:298: error: 'struct mm_struct' has no member named 'ioctx_list'
make[1]: *** [arch/s390/mm/pgtable.o] Error 1
Reported-by: Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de•ibm.com>
---
arch/s390/mm/pgtable.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff -urpN linux-2.6/arch/s390/mm/pgtable.c linux-2.6-patched/arch/s390/mm/pgtable.c
--- linux-2.6/arch/s390/mm/pgtable.c 2009-09-26 13:35:36.000000000 +0200
+++ linux-2.6-patched/arch/s390/mm/pgtable.c 2009-09-26 13:35:47.000000000 +0200
@@ -279,7 +279,10 @@ int s390_enable_sie(void)
/* lets check if we are allowed to replace the mm */
task_lock(tsk);
if (!tsk->mm || atomic_read(&tsk->mm->mm_users) > 1 ||
- tsk->mm != tsk->active_mm || !hlist_empty(&tsk->mm->ioctx_list)) {
+#ifdef CONFIG_AIO
+ !hlist_empty(&tsk->mm->ioctx_list) ||
+#endif
+ tsk->mm != tsk->active_mm) {
task_unlock(tsk);
return -EINVAL;
}
@@ -295,7 +298,10 @@ int s390_enable_sie(void)
/* Now lets check again if something happened */
task_lock(tsk);
if (!tsk->mm || atomic_read(&tsk->mm->mm_users) > 1 ||
- tsk->mm != tsk->active_mm || !hlist_empty(&tsk->mm->ioctx_list)) {
+#ifdef CONFIG_AIO
+ !hlist_empty(&tsk->mm->ioctx_list) ||
+#endif
+ tsk->mm != tsk->active_mm) {
mmput(mm);
task_unlock(tsk);
return -EINVAL;
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2009-09-26 11:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 3:38 linux-next: Tree for September 25 Stephen Rothwell
2009-09-25 13:19 ` linux-next: 20090925 - build breaks with !CONFIG_AIO Kamalesh Babulal
2009-09-26 11:37 ` Martin Schwidefsky [this message]
2009-09-25 13:31 ` linux-next: 20090925 - hvc driver build breaks with !HVC_CONSOLE Kamalesh Babulal
2009-09-25 22:20 ` [PATCH -next] i2c: uses/select RT_MUTEXES Randy Dunlap
2009-09-26 9:47 ` Jean Delvare
2009-09-25 22:20 ` [PATCH -next] input: serio_libps2 depends on serio_i8042 Randy Dunlap
2009-09-25 22:29 ` Dmitry Torokhov
2009-09-25 22:30 ` Randy Dunlap
2009-09-25 23:03 ` [PATCH -next] drbd: trace depends on TRACING Randy Dunlap
[not found] ` <4ABD4C28.9070202-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-09-29 15:32 ` Philipp Reisner
[not found] ` <200909291732.51383.philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org>
2009-09-29 15:37 ` Christoph Hellwig
2009-09-30 8:02 ` [Drbd-dev] " Lars Ellenberg
2009-09-30 16:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090926133702.44f315f7@mschwide.boeblingen.de.ibm.com \
--to=schwidefsky@de$(echo .)ibm.com \
--cc=adobriyan@gmail$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=kamalesh@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox