From: Martin Schwidefsky <schwidefsky@de•ibm.com>
To: Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>
Cc: linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
sfr@canb•auug.org.au, heiko.carstens@de•ibm.com,
linux-s390@vger•kernel.org
Subject: Re: linux-next: Tree for September 30
Date: Wed, 30 Sep 2009 14:16:41 +0200 [thread overview]
Message-ID: <20090930141641.3652fc99@mschwide.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20090930095254.GB5416@linux.vnet.ibm.com>
On Wed, 30 Sep 2009 15:22:54 +0530
Kamalesh Babulal <kamalesh@linux•vnet.ibm.com> wrote:
> next-20090930 randconfig build breaks, character driver
>
> ERROR: "ccw_device_force_console" [drivers/s390/char/raw3270.ko] undefined!
> make[1]: *** [__modpost] Error 1
This patch should fix the build breakage:
--
Subject: [PATCH] 3270 console build fix
From: Sebastian Ott <sebott@linux•vnet.ibm.com>
Fix this build failure:
drivers/s390/built-in.o: In function `raw3270_pm_unfreeze':
(.text+0x3ac04): undefined reference to `ccw_device_force_console'
with:
CONFIG_TN3270=y
CONFIG_TN3270_CONSOLE=n
CONFIG_TN3215_CONSOLE=n
Reported-by: Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>
Signed-off-by: Sebastian Ott <sebott@linux•vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de•ibm.com>
---
drivers/s390/char/raw3270.c | 2 ++
1 file changed, 2 insertions(+)
diff -urpN linux-2.6/drivers/s390/char/raw3270.c linux-2.6-patched/drivers/s390/char/raw3270.c
--- linux-2.6/drivers/s390/char/raw3270.c 2009-09-10 00:13:59.000000000 +0200
+++ linux-2.6-patched/drivers/s390/char/raw3270.c 2009-09-30 14:14:44.000000000 +0200
@@ -1361,11 +1361,13 @@ static int raw3270_pm_start(struct ccw_d
void raw3270_pm_unfreeze(struct raw3270_view *view)
{
+#ifdef CONFIG_TN3270_CONSOLE
struct raw3270 *rp;
rp = view->dev;
if (rp && test_bit(RAW3270_FLAGS_FROZEN, &rp->flags))
ccw_device_force_console();
+#endif
}
static struct ccw_device_id raw3270_id[] = {
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2009-09-30 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 3:37 linux-next: Tree for September 30 Stephen Rothwell
2009-09-30 9:52 ` Kamalesh Babulal
2009-09-30 12:16 ` Martin Schwidefsky [this message]
2009-09-30 16:58 ` Kamalesh Babulal
-- strict thread matches above, loose matches on Subject: below --
2010-09-30 4:45 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930141641.3652fc99@mschwide.boeblingen.de.ibm.com \
--to=schwidefsky@de$(echo .)ibm.com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=kamalesh@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox