Subject: Re: next-1007: dmar fails to build

From: Alexander Beregalov <[email-masked]>
Date: Wed, 7 Oct 2009 12:59:58 +0400

On Wed, Oct 07, 2009 at 12:50:39PM +0400, Alexander Beregalov wrote:
> drivers/pci/dmar.c: In function 'dmar_parse_one_rhsa':
> drivers/pci/dmar.c:360: error: implicit declaration of function
> 'acpi_map_pxm_to_node'
> 
> $ grep NUMA .config
> $

By the way, shouldn't it be as following?

diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
index 63aa529..474c7e8 100644
--- a/drivers/pci/dmar.c
+++ b/drivers/pci/dmar.c
@@ -362,8 +362,8 @@ dmar_parse_one_rhsa(struct acpi_dmar_header *header)
 			if (!node_online(node))
 				node = -1;
 			drhd->iommu->node = node;
-		return 0;
-	}
+			return 0;
+		}
 
 	return -ENODEV;
 }