From: Randy Dunlap <randy.dunlap@oracle•com>
To: Gregory Haskins <gregory.haskins@gmail•com>,
Gregory Haskins <ghaskins@novell•com>
Cc: Kamalesh Babulal <kamalesh@linux•vnet.ibm.com>,
sfr@canb•auug.org.au, greg@kroah•com, netdev@vger•kernel.org,
LKML <linux-kernel@vger•kernel.org>,
linux-next@vger•kernel.org
Subject: Re: [BUILD-FAILURE] next-20091015 - vbus_enet driver breaks with allmodconfig
Date: Thu, 15 Oct 2009 11:54:11 -0700 [thread overview]
Message-ID: <20091015115411.5b556047.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20091015114210.65e1be72.randy.dunlap@oracle.com>
On Thu, 15 Oct 2009 11:42:10 -0700 Randy Dunlap wrote:
> On Thu, 15 Oct 2009 13:39:44 -0400 Gregory Haskins wrote:
>
> > Gregory Haskins wrote:
> > >>>> On 10/15/2009 at 6:48 AM, in message
> > > <20091015104852.GA6740@linux•vnet.ibm.com>, Kamalesh Babulal
> > > <kamalesh@linux•vnet.ibm.com> wrote:
> > >> Hi Gregory,
> > >>
> > >> While building next-20091015 with allmodconfig on the powerpc
> > >> vbus-enet driver breaks
> > >
> > > Hi Kamalesh,
> > >
> > > I'll take a look at this and get a fix submitted today.
> > >
> > > Kind Regards,
> > > -Greg
> > >
> > >> MODPOST 2492 modules
> > >> ERROR: ".vbus_driver_register" [drivers/net/vbus-enet.ko] undefined!
> > >> ERROR: ".vbus_driver_unregister" [drivers/net/vbus-enet.ko] undefined!
> > >> ERROR: ".vbus_driver_ioq_alloc" [drivers/net/vbus-enet.ko] undefined!
> > >>
> > >> CONFIG_VBUS_ENET=m
> > >> CONFIG_VBUS_ENET_DEBUG=y
> > >> CONFIG_VBUS_PROXY=n
> >
> > Hi Kamalesh,
> >
> > I am having difficulty reproducing the problem. When I look at the
> > Kconfig, I see that VBUS_ENET has a "select VBUS_PROXY" as I would
> > expect. Additionally, if I run allmodconfig I can confirm that I get
> > VBUS_ENET=m, VBUS_PROXY=y:
>
> Greg,
>
> Did you try to reproduce it with the ppc64 config file?
> allmodconfig on what arch?
>
> I think the problem is that arch/x86/Kconfig says:
>
> source "drivers/vbus/Kconfig"
>
> and that should actually be in drivers/Kconfig, so that it applies
> to ppc64 et al, not just x86.
>
OTOH, drivers/vbus/pci-bridge.c uses create_irq(), which is implemented
only on x86 and ia64 and one ARM platform, so all of this ppc testing
seems to be invalid... ?
>
> > ghaskins@dev:~/sandbox/git/fabric/linux-2.6-next> rm .config
> > ghaskins@dev:~/sandbox/git/fabric/linux-2.6-next> make allmodconfig
> > scripts/kconfig/conf -m arch/x86/Kconfig
> > #
> > # configuration written to .config
> > #
> > ghaskins@dev:~/sandbox/git/fabric/linux-2.6-next> grep -i vbus .config
> > CONFIG_VBUS_PROXY=y
> > CONFIG_VBUS_PCIBRIDGE=y
> > CONFIG_VBUS_ENET=m
> > CONFIG_VBUS_ENET_DEBUG=y
> > CONFIG_USB_GADGET_VBUS_DRAW=2
> > CONFIG_USB_GPIO_VBUS=m
> >
> > I am not sure how your environment could have generated the VBUS_PROXY=n
> > outcome. Does anyone have any ideas?
> >
> > -Greg
---
~Randy
next prev parent reply other threads:[~2009-10-15 18:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 4:25 linux-next: Tree for October 15 Stephen Rothwell
2009-10-15 10:48 ` [BUILD-FAILURE] next-20091015 - vbus_enet driver breaks with allmodconfig Kamalesh Babulal
2009-10-15 11:21 ` Gregory Haskins
2009-10-15 17:39 ` Gregory Haskins
2009-10-15 18:42 ` Randy Dunlap
2009-10-15 18:54 ` Randy Dunlap [this message]
2009-10-15 22:25 ` Gregory Haskins
2009-11-06 17:38 ` Randy Dunlap
2009-11-06 19:02 ` Gregory Haskins
2009-10-16 0:29 ` Gregory Haskins
2009-10-15 19:17 ` linux-next: Tree for October 15 (i7core_edac) Randy Dunlap
2009-10-15 22:29 ` [PATCH -next] vmxnet3: use dev_dbg, fix build for CONFIG_BLOCK=n Randy Dunlap
2009-10-15 22:35 ` [Pv-drivers] " Bhavesh Davda
2009-10-15 22:42 ` Randy Dunlap
2009-10-15 22:47 ` Dmitry Torokhov
2009-10-15 22:53 ` Dmitry Torokhov
2009-10-15 22:53 ` Bhavesh Davda
2009-10-17 0:54 ` David Miller
2009-10-15 22:37 ` Shreyas Bhatewara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091015115411.5b556047.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=ghaskins@novell$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=gregory.haskins@gmail$(echo .)com \
--cc=kamalesh@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox