public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle•com>
To: Alexander Beregalov <a.beregalov@gmail•com>
Cc: linux-next <linux-next@vger•kernel.org>, jmoyer@redhat•com
Subject: Re: next-20091029: fs/aio.c build failure
Date: Thu, 29 Oct 2009 13:56:06 +0100	[thread overview]
Message-ID: <20091029125606.GK10727@kernel.dk> (raw)
In-Reply-To: <a4423d670910290540x21ab0692p90ebd04b5c3d62e@mail.gmail.com>

On Thu, Oct 29 2009, Alexander Beregalov wrote:
> Hi
> 
> fs/aio.c:1575: error: implicit declaration of function 'blk_run_address_space'
> 
> CONFIG_BLOCK is not set.

Not the first time this has happened, I think we should just pull the
bdi/mapping unplug functions out of CONFIG_BLOCK protection. They work
on the backing_dev, so they aren't inherently tied to just block IO.

This should fix it, I'll test and commit.

diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index b449e73..fcbc26a 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -331,4 +331,17 @@ static inline int bdi_sched_wait(void *word)
 	return 0;
 }
 
+static inline void blk_run_backing_dev(struct backing_dev_info *bdi,
+				       struct page *page)
+{
+	if (bdi && bdi->unplug_io_fn)
+		bdi->unplug_io_fn(bdi, page);
+}
+
+static inline void blk_run_address_space(struct address_space *mapping)
+{
+	if (mapping)
+		blk_run_backing_dev(mapping->backing_dev_info, NULL);
+}
+
 #endif		/* _LINUX_BACKING_DEV_H */
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 221cecd..39c601f 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -823,19 +823,6 @@ static inline struct request_queue *bdev_get_queue(struct block_device *bdev)
 	return bdev->bd_disk->queue;
 }
 
-static inline void blk_run_backing_dev(struct backing_dev_info *bdi,
-				       struct page *page)
-{
-	if (bdi && bdi->unplug_io_fn)
-		bdi->unplug_io_fn(bdi, page);
-}
-
-static inline void blk_run_address_space(struct address_space *mapping)
-{
-	if (mapping)
-		blk_run_backing_dev(mapping->backing_dev_info, NULL);
-}
-
 /*
  * blk_rq_pos()			: the current sector
  * blk_rq_bytes()		: bytes left in the entire request

-- 
Jens Axboe

  reply	other threads:[~2009-10-29 12:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-29 12:40 next-20091029: fs/aio.c build failure Alexander Beregalov
2009-10-29 12:56 ` Jens Axboe [this message]
2009-10-29 13:01   ` Jens Axboe
2009-10-29 13:07     ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091029125606.GK10727@kernel.dk \
    --to=jens.axboe@oracle$(echo .)com \
    --cc=a.beregalov@gmail$(echo .)com \
    --cc=jmoyer@redhat$(echo .)com \
    --cc=linux-next@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox