From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Thomas Gleixner <tglx@linutronix•de>, Ingo Molnar <mingo@elte•hu>,
"H. Peter Anvin" <hpa@zytor•com>,
Peter Zijlstra <peterz@infradead•org>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>
Subject: linux-next: tip tree build failure (Was: linux-next: tip tree build warning)
Date: Mon, 16 Nov 2009 18:01:18 +1100 [thread overview]
Message-ID: <20091116180118.aa1bf1e4.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20091116162503.7f083c3a.sfr@canb.auug.org.au>
Hi all,
On Mon, 16 Nov 2009 16:25:03 +1100 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> arch/x86/kernel/apic/apic.c: In function 'calibrate_APIC_clock':
> arch/x86/kernel/apic/apic.c:650: warning: format '%ld' expects type 'long int', but argument 2 has type 'u32'
>
> Introduced by commit 23af368e9a904f59256c27d371ce223d6cee0430
> ("clockevents: Use u32 for mult and shift factors").
Unfortunately, this produces this error on sparc64 (since they use -Werror
in arch/sparc) (sparc64 defconfig build):
arch/sparc/kernel/time_64.c: In function 'time_init':
arch/sparc/kernel/time_64.c:851: error: format '%lx' expects type 'long unsigned int', but argument 2 has type 'u32'
I applied the following patch:
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 16 Nov 2009 17:54:47 +1100
Subject: [PATCH] sparc: fix printk for change of variable type
The clockevent mult field became a u32.
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
arch/sparc/kernel/time_64.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/sparc/kernel/time_64.c b/arch/sparc/kernel/time_64.c
index da1218e..63f73ae 100644
--- a/arch/sparc/kernel/time_64.c
+++ b/arch/sparc/kernel/time_64.c
@@ -847,7 +847,7 @@ void __init time_init(void)
sparc64_clockevent.min_delta_ns =
clockevent_delta2ns(0xF, &sparc64_clockevent);
- printk("clockevent: mult[%lx] shift[%d]\n",
+ printk("clockevent: mult[%ux] shift[%d]\n",
sparc64_clockevent.mult, sparc64_clockevent.shift);
setup_sparc64_timer();
--
1.6.5.2
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
next prev parent reply other threads:[~2009-11-16 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 5:25 linux-next: tip tree build warning Stephen Rothwell
2009-11-16 7:01 ` Stephen Rothwell [this message]
2009-11-16 17:05 ` Randy Dunlap
2009-11-23 18:05 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116180118.aa1bf1e4.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=davem@davemloft$(echo .)net \
--cc=hpa@zytor$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@elte$(echo .)hu \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox