public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>, gregkh@suse•de
Cc: linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
	devel@driverdev•osuosl.org
Subject: [PATCH -next] sep: fix 2 warnings
Date: Tue, 17 Nov 2009 10:17:42 -0800	[thread overview]
Message-ID: <20091117101742.d512100e.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20091117195309.6cc3ead0.sfr@canb.auug.org.au>

From: Randy Dunlap <randy.dunlap@oracle•com>

Fix printk format warning:
drivers/staging/sep/sep_driver.c:276: warning: format '%08llx' expects type 'long long unsigned int', but argument 2 has type 'dma_addr_t'

and variable may be used uninitialized (correct):
drivers/staging/sep/sep_driver.c:1774: warning: 'error' may be used uninitialized in this function

Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
---
 drivers/staging/sep/sep_driver.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- linux-next-20091117.orig/drivers/staging/sep/sep_driver.c
+++ linux-next-20091117/drivers/staging/sep/sep_driver.c
@@ -273,7 +273,8 @@ static dma_addr_t sep_shared_virt_to_bus
 						void *virt_address)
 {
 	dma_addr_t pa = sep->shared_bus + (virt_address - sep->shared_addr);
-	edbg("sep: virt to bus b %08llx v %p\n", pa, virt_address);
+	edbg("sep: virt to bus b %08llx v %p\n",
+		(unsigned long long)pa, virt_address);
 	return pa;
 }
 
@@ -1788,6 +1789,7 @@ static int sep_create_flow_dma_tables_ha
 	first_table_data.physical_address = 0xffffffff;
 
 	/* find the free structure for flow data */
+	error = -EINVAL;
 	flow_context_ptr = sep_find_flow_context(sep, SEP_FREE_FLOW_ID);
 	if (flow_context_ptr == NULL)
 		goto end_function;

  parent reply	other threads:[~2009-11-17 18:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17  8:53 linux-next: Tree for November 17 Stephen Rothwell
2009-11-17 12:06 ` [-next Nov 17] s390 build break(arch/s390/kernel/compat_wrapper.S) Sachin Sant
2009-11-17 12:52   ` Heiko Carstens
2009-11-17 13:40     ` Eric Paris
2009-11-17 13:55       ` Heiko Carstens
2009-11-17 15:23         ` Eric Paris
2009-11-17 15:50           ` Heiko Carstens
2009-11-17 15:57             ` Eric Paris
2009-11-17 16:14               ` Heiko Carstens
2009-11-18  7:04           ` Heiko Carstens
2009-11-18  9:27             ` Russell King
2009-11-18 14:49             ` Ralf Baechle
2009-11-18 16:02             ` Eric Paris
2009-11-18 16:22               ` Heiko Carstens
2009-11-18 17:34               ` Martin Schwidefsky
2009-11-18 18:41                 ` Heiko Carstens
2009-11-19  8:54                   ` Martin Schwidefsky
2009-11-18 17:24             ` Eric Paris
2009-11-17 17:02 ` linux-next: Tree for November 17 (exofs) Randy Dunlap
2009-11-17 17:08   ` Boaz Harrosh
2009-11-17 17:10     ` Boaz Harrosh
2009-11-17 17:24       ` Boaz Harrosh
2009-11-17 17:48         ` Randy Dunlap
2009-11-17 18:17 ` Randy Dunlap [this message]
2009-11-17 18:29   ` [PATCH -next] sep: fix 2 warnings Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091117101742.d512100e.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle$(echo .)com \
    --cc=devel@driverdev$(echo .)osuosl.org \
    --cc=gregkh@suse$(echo .)de \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox