From: Ingo Molnar <mingo@elte•hu>
To: Tejun Heo <tj@kernel•org>
Cc: Peter Zijlstra <peterz@infradead•org>,
Steven Rostedt <rostedt@goodmis•org>,
Fr??d??ric Weisbecker <fweisbec@gmail•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Mike Galbraith <efault@gmx•de>,
Thomas Gleixner <tglx@linutronix•de>,
"H. Peter Anvin" <hpa@zytor•com>
Subject: Re: [PATCH 1/4 tip/sched/core] sched: rename preempt_notifier to sched_notifier and always enable it
Date: Fri, 27 Nov 2009 07:21:47 +0100 [thread overview]
Message-ID: <20091127062147.GB22149@elte.hu> (raw)
In-Reply-To: <4B0F6EA9.6070105@kernel.org>
* Tejun Heo <tj@kernel•org> wrote:
> 11/27/2009 03:13 PM, Ingo Molnar wrote:
> >>> My position on this is rather clear: i want no new callbacks and no
> >>> changes to callbacks in the scheduler until this situation is cleaned
> >>> up. Five callback sites are _way_ too much - so if you want to add
> >>> callbacks or change them, please clean it up and improve it first.
> >>
> >> Even changes which cause no functional differences? [...]
> >
> > Such as enabling preempt notifiers unconditionally? That's a functional
> > change - it turns a so-far optional callback into an essentially
> > mandatory one.
>
> No, I'm not gonna do that. Just patches to reorganize code so that
> unnecessary conflicts won't occur. There will be NO functional
> changes.
Not without the other changes - which you want to do too, right? Please
send all sched.c modifications via the scheduler tree. Going via other
trees is fine when there's agreement by the maintainers - but this is
one of the rare cases where that's not the case.
Ingo
next prev parent reply other threads:[~2009-11-27 6:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 8:00 linux-next: manual merge of the workqueues tree with the tip tree Stephen Rothwell
2009-11-26 8:12 ` Ingo Molnar
2009-11-26 9:15 ` Tejun Heo
2009-11-26 9:26 ` Ingo Molnar
2009-11-26 9:48 ` Tejun Heo
2009-11-26 9:51 ` Ingo Molnar
2009-11-26 10:11 ` [PATCH 1/4 tip/sched/core] sched: rename preempt_notifier to sched_notifier and always enable it Tejun Heo
2009-11-26 10:29 ` Ingo Molnar
2009-11-26 10:32 ` Peter Zijlstra
2009-11-26 11:23 ` Peter Zijlstra
2009-11-26 11:56 ` Ingo Molnar
2009-11-26 12:40 ` Peter Zijlstra
2009-11-27 2:11 ` Tejun Heo
2009-11-27 4:52 ` Ingo Molnar
2009-11-27 5:38 ` Tejun Heo
2009-11-27 5:46 ` Ingo Molnar
2009-11-27 6:01 ` Tejun Heo
2009-11-27 6:13 ` Ingo Molnar
2009-11-27 6:16 ` Tejun Heo
2009-11-27 6:21 ` Ingo Molnar [this message]
2009-11-27 6:38 ` Tejun Heo
2009-11-27 7:02 ` Ingo Molnar
2009-11-26 10:44 ` Tejun Heo
2009-11-27 3:33 ` Paul Mackerras
2009-11-27 4:54 ` Ingo Molnar
2009-11-26 10:13 ` [PATCH 2/4 tip/sched/core] sched: update sched_notifier and add wakeup/sleep notifications Tejun Heo
2009-11-26 10:13 ` [PATCH 3/4 tip/sched/core] sched: refactor try_to_wake_up() and implement try_to_wake_up_local() Tejun Heo
2009-11-26 10:14 ` [PATCH 4/4 tip/sched/core] sched: implement force_cpus_allowed() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091127062147.GB22149@elte.hu \
--to=mingo@elte$(echo .)hu \
--cc=efault@gmx$(echo .)de \
--cc=fweisbec@gmail$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox