From: Randy Dunlap <randy.dunlap@oracle•com>
To: Michal Nazarewicz <m.nazarewicz@samsung•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>, Greg KH <greg@kroah•com>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] USB: g_multi: Fixed '"CONFIG_USB_ETH_RNDIS" redefined' warning
Date: Sat, 28 Nov 2009 10:34:29 -0800 [thread overview]
Message-ID: <20091128103429.705670b2.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1259150386-7291-1-git-send-email-m.nazarewicz@samsung.com>
On Wed, 25 Nov 2009 12:59:46 +0100 Michal Nazarewicz wrote:
> From: Michal Nazarewicz <m.nazarewicz@samsung•com>
>
> CONFIG_USB_ETH_RNDIS may be defined when g_ether is built causing
> warning when multi.c tries to redefine its value. Changed to first
> undefine CONFIG_USB_ETH_RNDIS in multi.c.
Is there no kconfig way to solve this?
You shouldn't be messing with kconfig symbols in source files...
> Signed-off-by: Michal Nazarewicz <m.nazarewicz@samsung•com>
> ---
> drivers/usb/gadget/multi.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/gadget/multi.c b/drivers/usb/gadget/multi.c
> index 64711fe..227dc81 100644
> --- a/drivers/usb/gadget/multi.c
> +++ b/drivers/usb/gadget/multi.c
> @@ -26,6 +26,9 @@
> #include <linux/utsname.h>
>
>
> +#if defined CONFIG_USB_ETH_RNDIS
> +# undef CONFIG_USB_ETH_RNDIS
> +#endif
> #if defined CONFIG_USB_G_MULTI_RNDIS
> # define CONFIG_USB_ETH_RNDIS y
> #endif
> --
---
~Randy
next prev parent reply other threads:[~2009-11-28 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 11:35 linux-next: usb tree build warning Stephen Rothwell
2009-11-25 11:59 ` [PATCH] USB: g_multi: Fixed '"CONFIG_USB_ETH_RNDIS" redefined' warning Michal Nazarewicz
2009-11-28 18:34 ` Randy Dunlap [this message]
2009-11-30 9:55 ` [PATCH] USB: Added USB_ETH_RNDIS to use instead of CONFIG_USB_ETH_RNDIS Michal Nazarewicz
2009-12-01 6:43 ` Randy Dunlap
2010-01-22 13:48 ` [PATCH] USB: g_config: fix CONFIG_USB_G_MULTI_RNDIS usage Michal Nazarewicz
2010-01-22 14:18 ` [PATCH] USB: g_multi: " Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091128103429.705670b2.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=m.nazarewicz@samsung$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox