From: Russell King - ARM Linux <linux@arm•linux.org.uk>
To: Marc Zyngier <maz@misterjones•org>
Cc: Eric Miao <eric.y.miao@gmail•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Dominik Brodowski <linux@dominikbrodowski•net>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: linux-next: manual merge of the pcmcia tree with the pxa tree
Date: Mon, 30 Nov 2009 09:48:13 +0000 [thread overview]
Message-ID: <20091130094813.GC1638@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20091130102444.4ebc0a45@life-in-the-fast-lane>
On Mon, Nov 30, 2009 at 10:24:44AM +0100, Marc Zyngier wrote:
> Sounds good. I'll post rebased patches as soon as PCMCIA hits Linus'
> tree.
What would be a better idea is to rework the driver once my changes have
hit. If you need to pass additional data around, you can do it like this:
struct my_socket {
struct soc_pcmcia_socket skt;
...
};
#define to_my_socket(s) container_of(s, struct my_socket, skt)
static struct pcmcia_low_level my_ops = {
};
static int my_probe(struct platform_device *dev)
{
struct my_socket *skts;
pxa2xx_drv_pcmcia_ops(&my_ops);
skts = kzalloc(sizeof(*skts) * nr, GFP_KERNEL);
if (!skts)
...
for (i = 0; i < nr; i++) {
skts[i].skt.nr = i;
skts[i].skt.ops = &my_ops;
skts[i].skt.socket.owner = THIS_MODULE;
skts[i].skt.socket.parent = &dev->dev;
skts[i].skt.socket.pci_irq = the_socket_irq;
ret = pxa2xx_drv_pcmcia_add_one(&skts[i].skt);
if (ret)
goto free_registered_sockets_and_return_ret;
}
}
next prev parent reply other threads:[~2009-11-30 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 2:16 linux-next: manual merge of the pcmcia tree with the pxa tree Stephen Rothwell
2009-11-30 3:17 ` Eric Miao
2009-11-30 8:10 ` Marc Zyngier
2009-11-30 8:16 ` Eric Miao
2009-11-30 9:24 ` Marc Zyngier
2009-11-30 9:48 ` Russell King - ARM Linux [this message]
2009-12-06 9:49 ` Marc Zyngier
-- strict thread matches above, loose matches on Subject: below --
2009-11-30 2:16 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091130094813.GC1638@n2100.arm.linux.org.uk \
--to=linux@arm$(echo .)linux.org.uk \
--cc=eric.y.miao@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@dominikbrodowski$(echo .)net \
--cc=maz@misterjones$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox