From: David Miller <davem@davemloft•net>
To: randy.dunlap@oracle•com
Cc: sfr@canb•auug.org.au, netdev@vger•kernel.org,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH -next] net: niu uses crc32, so select CRC32
Date: Thu, 10 Dec 2009 13:51:38 -0800 (PST) [thread overview]
Message-ID: <20091210.135138.263963420.davem@davemloft.net> (raw)
In-Reply-To: <20091210093103.eda05dfe.randy.dunlap@oracle.com>
From: Randy Dunlap <randy.dunlap@oracle•com>
Date: Thu, 10 Dec 2009 09:31:03 -0800
> From: Randy Dunlap <randy.dunlap@oracle•com>
>
> niu drivers uses crc32 functions, so it needs to select CRC32.
>
> niu.c:(.text+0x18a7f8): undefined reference to `crc32_le'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
Applied, thanks Randy.
That dependency is quite indirect, it's due to ether_crc_*().
I bet a quick grep for that will find several other drivers
missing this Kconfig bit.
next prev parent reply other threads:[~2009-12-10 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 6:59 linux-next: Tree for December 10 Stephen Rothwell
2009-12-10 17:31 ` [PATCH -next] net: niu uses crc32, so select CRC32 Randy Dunlap
2009-12-10 21:51 ` David Miller [this message]
2009-12-10 21:59 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210.135138.263963420.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox