From: Randy Dunlap <randy.dunlap@oracle•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH -next] fs: fix compat_ioctl build for CONFIG_BLOCK=n
Date: Tue, 15 Dec 2009 11:29:34 -0800 [thread overview]
Message-ID: <20091215112934.020e5648.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200912142016.13631.arnd@arndb.de>
On Mon, 14 Dec 2009 20:16:13 +0000 Arnd Bergmann wrote:
> On Monday 14 December 2009 17:10:05 Randy Dunlap wrote:
> >
> > From: Randy Dunlap <randy.dunlap@oracle•com>
> >
> > Fix build failure when CONFIG_BLOCK=n:
> >
> > fs/compat_ioctl.c:1604: error: 'SG_SET_TRANSFORM' undeclared
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
>
> Your patch is obviously correct, but I wonder if we could just drop
> the line completely, given that no driver in the kernel actually
> implements this ioctl command. It was part of the ide-scsi driver
> until 2.6.28, but that driver was removed in 2.6.29.
I checked with Jens, he says yes, drop that case.
Do you want to do that or should I send another patch?
thanks,
---
~Randy
next prev parent reply other threads:[~2009-12-15 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 5:59 linux-next: Tree for December 14 Stephen Rothwell
2009-12-14 16:44 ` [PATCH] staging/vt66*: kconfig, depends on WLAN Randy Dunlap
2009-12-14 17:08 ` [PATCH -next] radio/si470x: #include <sched.h> Randy Dunlap
2009-12-14 17:10 ` [PATCH -next] fs: fix compat_ioctl build for CONFIG_BLOCK=n Randy Dunlap
2009-12-14 20:16 ` Arnd Bergmann
2009-12-15 19:29 ` Randy Dunlap [this message]
2009-12-14 19:06 ` linux-next: Tree for December 14 (nouveau & AGP) Randy Dunlap
2009-12-14 19:51 ` [PATCH -next] nouveau: fix ch7006 build Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091215112934.020e5648.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox