From: Randy Dunlap <randy.dunlap@oracle•com>
To: Borislav Petkov <petkovbb@googlemail•com>
Cc: "H. Peter Anvin" <hpa@zytor•com>,
Borislav Petkov <borislav.petkov@amd•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH -next] x86 msrs: alloc/free for CONFIG_SMP=n
Date: Wed, 16 Dec 2009 14:02:01 -0800 [thread overview]
Message-ID: <20091216140201.5ef21b90.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20091216215808.GB27228@liondog.tnic>
On Wed, 16 Dec 2009 22:58:08 +0100 Borislav Petkov wrote:
> On Wed, Dec 16, 2009 at 01:51:19PM -0800, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle•com>
> >
> > Rearrange arch/x86/lib/msr.c so that alloc/free are built and
> > usable when CONFIG_SMP=n. Fixes build of amd64_edac.
> >
> > ERROR: "msrs_free" [drivers/edac/amd64_edac_mod.ko] undefined!
> > ERROR: "msrs_alloc" [drivers/edac/amd64_edac_mod.ko] undefined!
> >
> > ---
> > arch/x86/lib/Makefile | 2 -
> > arch/x86/lib/msr.c | 42 ++++++++++++++++++++--------------------
> > 2 files changed, 23 insertions(+), 21 deletions(-)
>
> Haha, I just sent a very similar one :)
Yes, I noticed.
> >
> > --- linux-next-20091216.orig/arch/x86/lib/Makefile
> > +++ linux-next-20091216/arch/x86/lib/Makefile
> > @@ -14,7 +14,7 @@ $(obj)/inat.o: $(obj)/inat-tables.c
> >
> > clean-files := inat-tables.c
> >
> > -obj-$(CONFIG_SMP) := msr.o
> > +obj-$(CONFIG_X86_MSR) := msr.o
>
> however, CONFIG_X86_MSR is the x86 MSR access module and the <lib/msr.c>
> is the library of MSR accessing functions which is always in. So this
> should be unconditional as in my version or Peter might have a better
> idea...?
Sure, whichever is OK with me.
---
~Randy
next prev parent reply other threads:[~2009-12-16 22:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 7:32 linux-next: Tree for December 16 Stephen Rothwell
2009-12-16 17:24 ` linux-next: Tree for December 16 (amd64_edac) Randy Dunlap
2009-12-16 17:32 ` H. Peter Anvin
2009-12-16 17:45 ` Borislav Petkov
2009-12-16 18:36 ` H. Peter Anvin
2009-12-16 21:51 ` [PATCH -next] x86 msrs: alloc/free for CONFIG_SMP=n Randy Dunlap
2009-12-16 21:58 ` Borislav Petkov
2009-12-16 22:02 ` Randy Dunlap [this message]
2009-12-16 22:41 ` H. Peter Anvin
2009-12-16 23:16 ` Borislav Petkov
2009-12-16 21:54 ` linux-next: Tree for December 16 (amd64_edac) Borislav Petkov
2009-12-16 22:26 ` [PATCH -next] power: fix printk formats Randy Dunlap
2009-12-16 22:35 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091216140201.5ef21b90.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=borislav.petkov@amd$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=petkovbb@googlemail$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox