From: Greg KH <gregkh@suse•de>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Scott Smedley <ss@aao•gov.au>
Subject: Re: linux-next: Tree for December 19 (staging/dt3155)
Date: Fri, 18 Dec 2009 20:47:47 -0800 [thread overview]
Message-ID: <20091219044747.GB14503@suse.de> (raw)
In-Reply-To: <20091218191037.d6b4727b.randy.dunlap@oracle.com>
On Fri, Dec 18, 2009 at 07:10:37PM -0800, Randy Dunlap wrote:
> On Sat, 19 Dec 2009 11:04:57 +1100 Stephen Rothwell wrote:
>
> > Hi all,
> >
> > I said:
> > > News: there will be no linux-next releases until at least Dec 24 and,
> > > more likely, Dec 29. Have a Merry Christmas and take a break. :-)
> >
> > Well, I decided I had time for one more so it will be based in -rc1).
> >
> > This one has not had the build testing *between* merges, but has had all
> > the normal build testing at the end. Since the latter testing showed no
> > problems, this just means that there may be more unbisectable points in
> > the tree (but that is unlikely).
>
>
> When CONFIG_DT3155=y (i.e., not a loadable module):
Ick, I'll change that to 'M' now, it shouldn't be built in just yet for
the reasons you found.
I don't think the code has ever been built as 'y' as you just found out.
>
> (a)
> drivers/staging/dt3155/dt3155_drv.c:967: error: implicit declaration of function 'pci_find_device'
> drivers/staging/dt3155/dt3155_drv.c:1151: error: implicit declaration of function 'request_irq'
> drivers/staging/dt3155/dt3155_drv.c:1152: error: 'IRQF_SHARED' undeclared (first use in this function)
> drivers/staging/dt3155/dt3155_drv.c:1152: error: 'IRQF_DISABLED' undeclared (first use in this function)
> drivers/staging/dt3155/dt3155_drv.c:1195: error: implicit declaration of function 'free_irq'
>
>
> #ifdef MODULE
> #include <linux/interrupt.h>
>
> linux/interrupt.h is needed for DT3155=y, not just when DT3155=m.
>
> Oh, and this config has: # CONFIG_PCI_LEGACY is not set
> which accounts for pci_find_device() being unknown.
> If that is required (as it is currently, even though this function is
> deprecated), it can be expressed in the driver's Kconfig file:
> depends on PCI_LEGACY
>
I'll fix this up to just not need this anymore, as it should be fixed.
> (b) when compiling goes further:
>
> drivers/staging/dt3155/dt3155_drv.c:571: warning: format '%x' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
> drivers/staging/dt3155/dt3155_drv.c:571: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'
> drivers/staging/dt3155/dt3155_drv.c:657: warning: format '%x' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
> drivers/staging/dt3155/dt3155_drv.c:657: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'
>
>
>
> General:
>
> #ifndef CONFIG_PCI
> #error "DT3155 : Kernel PCI support not enabled (DT3155 drive requires PCI)"
> #endif
>
> That should be handled via Kconfig, not in a .c file.
> Ah, it is done in Kconfig, so those lines above (in .c file) can be deleted.
Yes, lots of stuff in the .c file can be deleted :)
thanks,
greg k-h
next prev parent reply other threads:[~2009-12-19 4:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 0:04 linux-next: Tree for December 19 Stephen Rothwell
2009-12-19 3:10 ` linux-next: Tree for December 19 (staging/dt3155) Randy Dunlap
2009-12-19 4:47 ` Greg KH [this message]
2010-02-11 16:44 ` Randy Dunlap
2010-02-11 16:54 ` Greg KH
2009-12-19 3:18 ` linux-next: Tree for December 19 (media/mantis) Randy Dunlap
2009-12-19 17:11 ` Manu Abraham
2009-12-19 18:30 ` Randy Dunlap
2009-12-19 8:42 ` linux-next: Tree for December 19 Geert Uytterhoeven
2009-12-23 7:52 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091219044747.GB14503@suse.de \
--to=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=ss@aao$(echo .)gov.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox