From: Randy Dunlap <rdunlap@xenotime•net>
To: Michal Marek <mmarek@suse•cz>
Cc: Dominik Brodowski <linux@dominikbrodowski•net>,
Randy Dunlap <rdunlap@xenotime•net>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-kbuild@vger•kernel.org, linux-next@vger•kernel.org,
LKML <linux-kernel@vger•kernel.org>,
Valdis.Kletnieks@vt•edu
Subject: Re: linux-next: Tree for January 7 (pcmcia)
Date: Thu, 7 Jan 2010 13:55:57 -0800 [thread overview]
Message-ID: <20100107135557.989c9585.rdunlap@xenotime.net> (raw)
In-Reply-To: <20100107210744.GA10320@sepie.suse.cz>
On Thu, 7 Jan 2010 22:07:44 +0100 Michal Marek wrote:
> On Thu, Jan 07, 2010 at 09:57:28PM +0100, Dominik Brodowski wrote:
> > Hey,
> >
> > On Thu, Jan 07, 2010 at 10:10:06AM -0800, Randy Dunlap wrote:
> > > > Hi all,
> > > >
> > > > Changes since 20100106:
> > >
> > >
> > > drivers/built-in.o: In function `yenta_probe':
> > > yenta_socket.c:(.devinit.text+0x1e582): undefined reference to `pccard_nonstatic_ops'
> > >
> > > CONFIG_PCCARD=y
> > > CONFIG_PCMCIA=m
> > > CONFIG_PCCARD_NONSTATIC=m
> > > CONFIG_YENTA=y
> > >
> > > so yenta code (built-in) tries to reference data that lives in a
> > > loadable module.
> >
> > Uh, that was I. If kconfig can't be fixed easily, I'll revert the change
>
> Hi Randy, Dominik,
>
> Please try this one-liner. The problem is that 'if X' and 'if X!=n' are not
> the same in ternary logic.
>
> Michal
>
> From e7b12e70272484da2161c0b6c459f2eff2a989a8 Mon Sep 17 00:00:00 2001
> From: Michal Marek <mmarek@suse•cz>
> Date: Thu, 7 Jan 2010 21:03:11 +0100
> Subject: [PATCH] pcmcia: fix yenta dependency on PCCARD_NONSTATIC
>
> With CONFIG_PCMCIA=m and CONFIG_YENTA=y, we get
>
> drivers/built-in.o: In function `yenta_probe':
> yenta_socket.c:(.devinit.text+0x1e582): undefined reference to
> `pccard_nonstatic_ops'
>
> This is because
>
> select PCCARD_NONSTATIC if PCMCIA
>
> sets PCCARD_NONSTATIC = min(YENTA, PCMCIA). Change it to 'if PCMCIA!=n'
> to remove the upper limit.
>
> Reported-by: Randy Dunlap <rdunlap@xenotime•net>
> Signed-off-by: Michal Marek <mmarek@suse•cz>
Acked-by: Randy Dunlap <rdunlap@xenotime•net>
Thanks.
> ---
> drivers/pcmcia/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
> index 5cea8ba..e196a19 100644
> --- a/drivers/pcmcia/Kconfig
> +++ b/drivers/pcmcia/Kconfig
> @@ -84,7 +84,7 @@ config YENTA
> tristate "CardBus yenta-compatible bridge support"
> depends on PCI
> select CARDBUS if !EMBEDDED
> - select PCCARD_NONSTATIC if PCMCIA
> + select PCCARD_NONSTATIC if PCMCIA != n
> ---help---
> This option enables support for CardBus host bridges. Virtually
> all modern PCMCIA bridges are CardBus compatible. A "bridge" is
> --
> 1.6.5.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
---
~Randy
next prev parent reply other threads:[~2010-01-07 21:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 6:21 linux-next: Tree for January 7 Stephen Rothwell
2010-01-07 18:10 ` linux-next: Tree for January 7 (pcmcia) Randy Dunlap
2010-01-07 20:57 ` Dominik Brodowski
2010-01-07 21:07 ` Michal Marek
2010-01-07 21:55 ` Randy Dunlap [this message]
2010-01-08 17:54 ` Dominik Brodowski
2010-01-08 19:24 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107135557.989c9585.rdunlap@xenotime.net \
--to=rdunlap@xenotime$(echo .)net \
--cc=Valdis.Kletnieks@vt$(echo .)edu \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@dominikbrodowski$(echo .)net \
--cc=mmarek@suse$(echo .)cz \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox