From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Jun'ichi Nomura <j-nomura@ce•jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation•org>,
Al Viro <viro@zeniv•linux.org.uk>,
Valdis.Kletnieks@vt•edu, linux-kernel@vger•kernel.org,
linux-fsdevel@vger•kernel.org, linux-s390@vger•kernel.org,
linux-next@vger•kernel.org,
Heiko Carstens <heiko.carstens@de•ibm.com>
Subject: Re: mmotm 2010-02-10 - BUG at fs/dcache.c:677!
Date: Fri, 12 Feb 2010 16:30:42 +1100 [thread overview]
Message-ID: <20100212163042.da2fb31d.sfr@canb.auug.org.au> (raw)
In-Reply-To: <4B74DE40.5030401@ce.jp.nec.com>
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
Hi all,
On Fri, 12 Feb 2010 13:51:12 +0900 "Jun'ichi Nomura" <j-nomura@ce•jp.nec.com> wrote:
>
> So the bug seems introduced between next-20100205 and next-20100208.
>
> Isn't this change missing the equivalent of "dput(old)"?
>
> In patch-v2.6.33-rc7-next-20100208:
> > diff --git a/fs/namei.c b/fs/namei.c
> > index 94a5e60..a056dad 100644
> > --- a/fs/namei.c
> > +++ b/fs/namei.c
> > @@ -689,33 +689,17 @@ static __always_inline void follow_dotdot(struct nameidata *nd)
> ...
> > - spin_lock(&dcache_lock);
> > if (nd->path.dentry != nd->path.mnt->mnt_root) {
> > - nd->path.dentry = dget(nd->path.dentry->d_parent);
> > - spin_unlock(&dcache_lock);
> > - dput(old);
> > + /* rare case of legitimate dget_parent()... */
> > + nd->path.dentry = dget_parent(nd->path.dentry);
> > break;
> > }
That is part of commit 12578f932a8ad5f01bbf957d9c941760ef0dc575 ("Clean
follow_dotdot() up a bit") from the vfs tree.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2010-02-12 5:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201002110043.o1B0hKxW008835@imap1.linux-foundation.org>
[not found] ` <8576.1265942657@localhost>
2010-02-12 3:14 ` mmotm 2010-02-10 - BUG at fs/dcache.c:677! Andrew Morton
2010-02-12 4:51 ` Jun'ichi Nomura
2010-02-12 5:01 ` Al Viro
2010-02-12 5:07 ` Al Viro
2010-02-12 5:30 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212163042.da2fb31d.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=Valdis.Kletnieks@vt$(echo .)edu \
--cc=akpm@linux-foundation$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=j-nomura@ce$(echo .)jp.nec.com \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox