public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime•net>
To: linux-next@vger•kernel.org, akpm <akpm@linux-foundation•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
	LKML <linux-kernel@vger•kernel.org>,
	scsi <linux-scsi@vger•kernel.org>,
	"James E.J. Bottomley" <James.Bottomley@suse•de>
Subject: [PATCH -next] scsi: RAID_ATTRS depends on SCSI
Date: Sun, 21 Feb 2010 19:46:36 -0800	[thread overview]
Message-ID: <20100221194636.ef885e5a.rdunlap@xenotime.net> (raw)
In-Reply-To: <4B7EC8AE.60200@oracle.com>

From: Randy Dunlap <randy.dunlap@oracle•com>

raid_class uses scsi interfaces, so it should depend on SCSI.
Otherwise build errors occur when RAID_ATTRS=y and SCSI=m:

ERROR: "raid_class_release" [drivers/scsi/mpt2sas/mpt2sas.ko] undefined!
ERROR: "raid_class_attach" [drivers/scsi/mpt2sas/mpt2sas.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
---
 drivers/scsi/Kconfig |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

--- linux-next-20100219.orig/drivers/scsi/Kconfig
+++ linux-next-20100219/drivers/scsi/Kconfig
@@ -1,12 +1,5 @@
 menu "SCSI device support"
 
-config RAID_ATTRS
-	tristate "RAID Transport Class"
-	default n
-	depends on BLOCK
-	---help---
-	  Provides RAID
-
 config SCSI
 	tristate "SCSI device support"
 	depends on BLOCK
@@ -34,6 +27,13 @@ config SCSI_DMA
 	bool
 	default n
 
+config RAID_ATTRS
+	tristate "RAID Transport Class"
+	default n
+	depends on BLOCK && SCSI
+	---help---
+	  Provides RAID
+
 config SCSI_TGT
 	tristate "SCSI target support"
 	depends on SCSI && EXPERIMENTAL

  reply	other threads:[~2010-02-22  3:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-19  6:47 linux-next: Tree for February 19 Stephen Rothwell
2010-02-19 17:21 ` linux-next: Tree for February 19 (scsi/mpt2sas/raid_class) Randy Dunlap
2010-02-22  3:46   ` Randy Dunlap [this message]
2010-03-02 11:26     ` [origin tree build failure] Re: [PATCH -next] scsi: RAID_ATTRS depends on SCSI Ingo Molnar
2010-03-02 23:30       ` Stephen Rothwell
2010-03-03  5:36     ` James Bottomley
2010-03-03  6:17       ` Stephen Rothwell
2010-03-03 16:56       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100221194636.ef885e5a.rdunlap@xenotime.net \
    --to=rdunlap@xenotime$(echo .)net \
    --cc=James.Bottomley@suse$(echo .)de \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux-scsi@vger$(echo .)kernel.org \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox