Subject: Re: [PATCH -next] staging/pohmelfs: fix write_inode parameter warning

From: Stephen Rothwell <[email-masked]>
Date: Fri, 26 Feb 2010 11:41:18 +1100

Hi Randy,

On Thu, 25 Feb 2010 14:41:22 -0800 Randy Dunlap <[email-masked]> wrote:
>
> From: Randy Dunlap <[email-masked]>
> 
> sparse warns that:
> drivers/staging/pohmelfs/inode.c:1797: warning: initialization from incompatible pointer type
> 
> so fix pohmelfs_write_inode() to have the expected parameters.
> 
> Signed-off-by: Randy Dunlap <[email-masked]>
> ---
>  drivers/staging/pohmelfs/inode.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-next-20100225.orig/drivers/staging/pohmelfs/inode.c
> +++ linux-next-20100225/drivers/staging/pohmelfs/inode.c
> @@ -396,7 +396,8 @@ int pohmelfs_remove_child(struct pohmelf
>  /*
>   * Writeback for given inode.
>   */
> -static int pohmelfs_write_inode(struct inode *inode, int sync)
> +static int pohmelfs_write_inode(struct inode *inode,
> +				struct writeback_control *wbc)
>  {
>  	struct pohmelfs_inode *pi = POHMELFS_I(inode);
>  

This patch is OK, but depends on changes that are in the vfs tree that
are not in Linus' tree yet.

-- 
Cheers,
Stephen Rothwell                    [email-masked]
http://www.canb.auug.org.au/~sfr/