From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Jiri Kosina <jkosina@suse•cz>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
"Bruno Prémont" <bonbons@linux-vserver•org>
Subject: Re: linux-next: build failure after merge of the final tree (hid tree related)
Date: Thu, 1 Apr 2010 18:35:30 +1100 [thread overview]
Message-ID: <20100401183530.516bbca6.sfr@canb.auug.org.au> (raw)
In-Reply-To: <alpine.LNX.2.00.1004010817420.8345@pobox.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
Hi Jiri,
On Thu, 1 Apr 2010 08:18:43 +0200 (CEST) Jiri Kosina <jkosina@suse•cz> wrote:
>
> On Thu, 1 Apr 2010, Stephen Rothwell wrote:
>
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/hid/hid-picolcd.c: In function 'picolcd_debug_reset_write':
> > drivers/hid/hid-picolcd.c:1343: error: implicit declaration of function 'copy_from_user'
> > drivers/hid/hid-picolcd.c: In function 'picolcd_debug_eeprom_read':
> > drivers/hid/hid-picolcd.c:1407: error: implicit declaration of function 'copy_to_user'
> >
> > Caused by commit 9bbf2b98ba11d00bd73e3254e15cfe17ccaff6ba ("HID: add
> > experimental access to PicoLCD device's EEPROM and FLASH"). Using copy_
> > {to,from}_user requires the include of linux/uaccess.h.
> >
> > I have reverted that commit for today.
>
> Hmm, on which arch did this bomb out? I wonder why it is building fine for
> me.
PowerPC (see above). It could also be some interaction with another tree
in linux-next.
> Anyway, I have added the include, as it is obviously correct(tm), thanks
> for reporting it.
Thanks.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-04-01 7:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 6:06 linux-next: build failure after merge of the final tree (hid tree related) Stephen Rothwell
2010-04-01 6:18 ` Jiri Kosina
2010-04-01 7:35 ` Stephen Rothwell [this message]
2010-04-01 7:53 ` Bruno Prémont
2010-04-01 19:05 ` Bruno Prémont
-- strict thread matches above, loose matches on Subject: below --
2012-08-16 5:25 Stephen Rothwell
2012-08-16 10:05 ` Jiri Kosina
2012-08-16 11:14 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401183530.516bbca6.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=bonbons@linux-vserver$(echo .)org \
--cc=jkosina@suse$(echo .)cz \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox