Subject: Re: linux-next: build failure after merge of the mfd tree

From: Samuel Ortiz <[email-masked]>
Date: Thu, 8 Apr 2010 11:33:46 +0200

Hi Stephen,

On Thu, Apr 08, 2010 at 12:57:21PM +1000, Stephen Rothwell wrote:
> Hi Samuel,
> 
> After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/mfd/tps6507x.c: In function 'tps6507x_i2c_probe':
> drivers/mfd/tps6507x.c:90: error: implicit declaration of function 'kzalloc'
> drivers/mfd/tps6507x.c:90: warning: assignment makes pointer from integer without a cast
> drivers/mfd/tps6507x.c:92: error: implicit declaration of function 'kfree'
> 
> Caused by commit 353dd1bf937f319eb6fdf35a461bf0bea1361d23 ("mfd: Add
> TPS6507x support").
Fixed in my for-next branch, thanks for the report.

Cheers,
Samuel.

> I applied the following patch for today.
> 
> From: Stephen Rothwell <[email-masked]>
> Date: Thu, 8 Apr 2010 12:53:32 +1000
> Subject: [PATCH] mfd: TPS6507x: using kzalloc/kfree requires including slab.h
> 
> Signed-off-by: Stephen Rothwell <[email-masked]>
> ---
>  drivers/mfd/tps6507x.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c
> index dcddef0..d859dff 100644
> --- a/drivers/mfd/tps6507x.c
> +++ b/drivers/mfd/tps6507x.c
> @@ -17,6 +17,7 @@
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
>  #include <linux/init.h>
> +#include <linux/slab.h>
>  #include <linux/i2c.h>
>  #include <linux/mfd/core.h>
>  #include <linux/mfd/tps6507x.h>
> -- 
> 1.7.0.4
> 
> -- 
> Cheers,
> Stephen Rothwell                    [email-masked]
> http://www.canb.auug.org.au/~sfr/

-- 
Intel Open Source Technology Centre
http://oss.intel.com/