From: Stephen Rothwell <sfr@canb•auug.org.au>
To: David Woodhouse <dwmw2@infradead•org>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Maxim Levitsky <maximlevitsky@gmail•com>,
Andrew Morton <akpm@linux-foundation•org>
Subject: linux-next: build failure after merge of the mtd tree
Date: Thu, 8 Apr 2010 11:42:35 +1000 [thread overview]
Message-ID: <20100408114235.845264d0.sfr@canb.auug.org.au> (raw)
Hi David,
After merging the mtd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/mtd/sm_ftl.c: In function 'sm_cache_flush':
drivers/mtd/sm_ftl.c:937: error: implicit declaration of function 'for_each_bit'
drivers/mtd/sm_ftl.c:938: error: expected ';' before '{' token
drivers/mtd/sm_ftl.c:964: error: label 'restart' used but not defined
OK, not a suprise since Andrew submitted the "remove for_each_bit" patch
and you haven't applied the patch below to the mtd tree. Commit
7d17c02a01a111f40986859f044c8c4cce8a4aa6 ("mtd: Add new SmartMedia/xD
FTL") introduces a new use of "for_each_bit". I have applied the below
patch for today, please add it to the mtd tree ASAP.
Subject: [patch 1/1] bitops: rename for_each_bit() to for_each_set_bit(): mtd
To: dwmw2@infradead•org
Cc: akpm@linux-foundation•org, akinobu.mita@gmail•com, adobriyan@gmail•com,
davem@davemloft•net, dedekind@infradead•org, rmk@arm•linux.org.uk,
sfr@canb•auug.org.au
From: akpm@linux-foundation•org
Date: Mon, 05 Apr 2010 13:53:35 -0700
From: Akinobu Mita <akinobu.mita@gmail•com>
Rename for_each_bit() to for_each_set_bit in the kernel source tree. To
permit for_each_clear_bit(), should that ever be added.
I'll be sending a patch to Linus this week which removes the temporary
for_each_bit() macro, so this patch will be needed to avoid build
breakage.
Suggested-by: Alexey Dobriyan <adobriyan@gmail•com>
Suggested-by: Andrew Morton <akpm@linux-foundation•org>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>
Cc: Russell King <rmk@arm•linux.org.uk>
Cc: David Woodhouse <dwmw2@infradead•org>
Cc: Artem Bityutskiy <dedekind@infradead•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
---
drivers/mtd/sm_ftl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/mtd/sm_ftl.c~bitops-rename-for_each_bit-to-for_each_set_bit-mtd drivers/mtd/sm_ftl.c
--- a/drivers/mtd/sm_ftl.c~bitops-rename-for_each_bit-to-for_each_set_bit-mtd
+++ a/drivers/mtd/sm_ftl.c
@@ -934,7 +934,7 @@ int sm_cache_flush(struct sm_ftl *ftl)
/* Try to read all unread areas of the cache block*/
- for_each_bit(sector_num, &ftl->cache_data_invalid_bitmap,
+ for_each_set_bit(sector_num, &ftl->cache_data_invalid_bitmap,
ftl->block_size / SM_SECTOR_SIZE) {
if (!sm_read_sector(ftl,
_
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
next reply other threads:[~2010-04-08 1:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 1:42 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-15 1:28 linux-next: build failure after merge of the mtd tree Stephen Rothwell
2021-02-15 8:55 ` Rafał Miłecki
2025-09-02 2:08 Stephen Rothwell
2025-09-02 5:25 ` Mahapatra, Amit Kumar
2025-09-02 5:45 ` Stephen Rothwell
2026-01-30 15:47 Mark Brown
2026-02-02 8:47 ` Miquel Raynal
2026-03-12 13:14 Mark Brown
2026-03-12 14:22 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408114235.845264d0.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=dwmw2@infradead$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=maximlevitsky@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox