From: David Miller <davem@davemloft•net>
To: mingo@elte•hu
Cc: sfr@canb•auug.org.au, tglx@linutronix•de, hpa@zytor•com,
peterz@infradead•org, linux-next@vger•kernel.org,
linux-kernel@vger•kernel.org, fweisbec@gmail•com,
linuxppc-dev@lists•ozlabs.org
Subject: Re: linux-next: PowerPC WARN_ON_ONCE() after merge of the final tree (tip related)
Date: Wed, 14 Apr 2010 23:55:57 -0700 (PDT) [thread overview]
Message-ID: <20100414.235557.123118153.davem@davemloft.net> (raw)
In-Reply-To: <20100415064940.GA9240@elte.hu>
From: Ingo Molnar <mingo@elte•hu>
Date: Thu, 15 Apr 2010 08:49:40 +0200
> Btw., WARN_ON trapping on PowerPC is clearly a PowerPC bug - there's a good
> reason we have WARN_ON versus BUG_ON - it should be fixed.
I disagree, an implementation should be allowed to use the most
efficient implementation possible for both interfaces.
I would be using traps for both on sparc64 if that were really
feasible on sparc64 (and actually with gcc-4.5's "asm goto" it might
actually be now)
The WARN and BUG macros, when implemented without traps, have serious
implications for overall code size and register pressure.
next prev parent reply other threads:[~2010-04-15 6:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 6:12 linux-next: boot failure after merge of the final tree (tip related) Stephen Rothwell
2010-04-15 6:48 ` Benjamin Herrenschmidt
2010-04-15 6:49 ` linux-next: PowerPC WARN_ON_ONCE() " Ingo Molnar
2010-04-15 6:55 ` David Miller [this message]
2010-04-15 7:32 ` Ingo Molnar
2010-04-16 1:51 ` Benjamin Herrenschmidt
2010-04-16 1:56 ` Benjamin Herrenschmidt
2010-04-15 10:04 ` Stephen Rothwell
2010-04-15 13:00 ` Frederic Weisbecker
2010-04-15 14:03 ` Ingo Molnar
2010-04-15 17:15 ` Frederic Weisbecker
2010-04-16 10:38 ` Peter Zijlstra
2010-04-16 12:32 ` Frederic Weisbecker
2010-04-15 17:24 ` Frederic Weisbecker
2010-04-15 17:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100414.235557.123118153.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=fweisbec@gmail$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@elte$(echo .)hu \
--cc=peterz@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox