From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Greg KH <greg@kroah•com>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
"Eric W. Biederman" <ebiederm@xmission•com>,
Benjamin Thery <benjamin.thery@bull•net>,
NeilBrown <neilb@suse•de>
Subject: linux-next: build failure after merge of the staging-next tree
Date: Fri, 30 Apr 2010 15:52:05 +1000 [thread overview]
Message-ID: <20100430155205.a4171034.sfr@canb.auug.org.au> (raw)
Hi Greg,
After merging the staging-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/md/md.c: In function 'level_store':
drivers/md/md.c:3029: error: too few arguments to function 'sysfs_get_dirent'
Caused by commit 262f8e4937e7b4a587923ca3c039a184668f49ec ("sysfs:
Implement sysfs tagged directory support") from the driver-core tree
interacting with commit fecc531e3cc0de60514d326c7d82f1075ed55888 ("md:
manage redundancy group in sysfs when changing level") from the md.
I have applied this fixup patch for today and can carry it as necessary.
[This could have been avoided, of course, by creating a new API (maybe
sysfs_get_dirent_tagged) and implementing the old API in terms of that].
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Fri, 30 Apr 2010 15:00:20 +1000
Subject: [PATCH] md: fixup for sysfs_get_dirent API change
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/md/md.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 7f23558..b075b26 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3026,7 +3026,7 @@ level_store(mddev_t *mddev, const char *buf, size_t len)
printk(KERN_WARNING
"md: cannot register extra attributes for %s\n",
mdname(mddev));
- mddev->sysfs_action = sysfs_get_dirent(mddev->kobj.sd, "sync_action");
+ mddev->sysfs_action = sysfs_get_dirent(mddev->kobj.sd, NULL, "sync_action");
}
if (mddev->pers->sync_request != NULL &&
pers->sync_request == NULL) {
--
1.7.1
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
next reply other threads:[~2010-04-30 17:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 5:52 Stephen Rothwell [this message]
2010-04-30 14:43 ` linux-next: build failure after merge of the staging-next tree Greg KH
2010-05-18 5:30 ` Neil Brown
2010-05-21 23:36 ` Greg KH
2010-05-22 0:20 ` Neil Brown
2010-05-22 14:49 ` Greg KH
2010-05-22 15:54 ` Sage Weil
2010-05-01 17:48 ` Greg KH
2010-05-02 4:55 ` Eric W. Biederman
-- strict thread matches above, loose matches on Subject: below --
2010-04-30 5:52 Stephen Rothwell
2010-04-30 14:41 ` Greg KH
2010-04-30 5:50 Stephen Rothwell
2010-04-30 14:45 ` Greg KH
2010-04-30 15:08 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100430155205.a4171034.sfr@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=benjamin.thery@bull$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=neilb@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox