From: "Peter Hüwe" <PeterHuewe@gmx•de>
To: devel@linuxdriverproject•org
Cc: Joe Perches <joe@perches•com>,
Randy Dunlap <randy.dunlap@oracle•com>,
devel@driverdev•osuosl.org,
Stephen Rothwell <sfr@canb•auug.org.au>,
gregkh@suse•de, support@sbei•com,
LKML <linux-kernel@vger•kernel.org>,
linux-next@vger•kernel.org, support@onestopsystems•com
Subject: Re: [PATCH -next] staging/cxt1e1: Convert bare printks to pr_<level>
Date: Wed, 5 May 2010 14:21:14 +0200 [thread overview]
Message-ID: <201005051421.14647.PeterHuewe@gmx.de> (raw)
In-Reply-To: <1272915196.30040.163.camel@Joe-Laptop.home>
Am Montag 03 Mai 2010 21:33:16 schrieb Joe Perches:
> Added #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> A few line splits for long arguments
> A couple of embedded function names converted to "%s", __func__
> Removed some uses of THIS_MODULE->name
>
> Signed-off-by: Joe Perches <joe@perches•com>
Hi,
I applied Joe's patch, but unfortunately it misses out one part of Randy's
original patch, i.e. the conversion in line 286 of hwprobe.c.
Joe: Can you perhaps add this to your patch?
Thanks,
Peter
Signed-off-by: Peter Huewe <peterhuewe@gmx•de>
---
Copied from original Patch by Randy dunlap
--- linux-next-20100503.orig/drivers/staging/cxt1e1/hwprobe.c
+++ linux-next-20100503/drivers/staging/cxt1e1/hwprobe.c
@@ -282,7 +283,7 @@ c4_hdw_init (struct pci_dev * pdev, int
*/
char *cp = hi->devname;
- strcpy (cp, THIS_MODULE->name);
+ strcpy (cp, KBUILD_MODNAME);
cp += strlen (cp); /* reposition */
*cp++ = '-';
*cp++ = '0' + (found / 2); /* there are two found interfaces per
next prev parent reply other threads:[~2010-05-05 12:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 5:16 linux-next: Tree for May 3 Stephen Rothwell
2010-05-03 17:06 ` [PATCH -next] power: fix block_io.c printk warning Randy Dunlap
2010-05-03 22:00 ` Rafael J. Wysocki
[not found] ` <20100503151619.f75e3a80.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-05-03 17:07 ` [PATCH -next] usbserial: fix mos7720 dependencies Randy Dunlap
2010-05-03 17:09 ` [PATCH -next] staging: fix cxt1e1 module names Randy Dunlap
2010-05-03 18:02 ` Joe Perches
2010-05-03 18:06 ` Randy Dunlap
2010-05-03 19:33 ` [PATCH -next] staging/cxt1e1: Convert bare printks to pr_<level> Joe Perches
2010-05-05 12:21 ` Peter Hüwe [this message]
2010-05-05 16:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005051421.14647.PeterHuewe@gmx.de \
--to=peterhuewe@gmx$(echo .)de \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=devel@linuxdriverproject$(echo .)org \
--cc=gregkh@suse$(echo .)de \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=support@onestopsystems$(echo .)com \
--cc=support@sbei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox