Subject: Re: [PATCH -next] staging/rar_register: depends on PCI

From: Alan Cox <[email-masked]>
Date: Thu, 6 May 2010 00:55:57 +0100

On Wed, 5 May 2010 15:45:22 -0700
Randy Dunlap <[email-masked]> wrote:

> From: Randy Dunlap <[email-masked]>
> 
> rar_register driver uses PCI interfaces and PCI devices, so it
> should depend on PCI.
> 
> Also format the Kconfig help text as normally done.
> 
> drivers/staging/rar_register/rar_register.c:623: error: implicit declaration of function 'pci_dev_get'
> drivers/staging/rar_register/rar_register.c:623: warning: assignment makes pointer from integer without a cast
> 
> Note:  The memrar driver selects this driver's Kconfig symbol, even when
> PCI is not enabled.  That select could be changed to
> 	select RAR_REGISTER if PCI
> but that would still result in build errors when PCI is not enabled, namely:
> drivers/built-in.o: In function `memrar_fini_rar_resources':
> memrar_handler.c:(.text+0x2391b7): undefined reference to `unregister_rar'
> drivers/built-in.o: In function `memrar_registration_callback':
> memrar_handler.c:(.text+0x23925a): undefined reference to `rar_get_address'
> drivers/built-in.o: In function `memrar_init':
> memrar_handler.c:(.init.text+0x12c7b): undefined reference to `register_rar'
> memrar_handler.c:(.init.text+0x12c97): undefined reference to `register_rar'
> 
> Does anyone have suggestions for this?

Yes - memrar should depend upon the RAR_REGISTER

> 
> Signed-off-by: Randy Dunlap <[email-masked]>

Acked-by: Alan Cox <[email-masked]>