Subject: Re: [PATCH -next] bridge: fix build for CONFIG_SYSFS disabled

From: David Miller <[email-masked]>
Date: Mon, 17 May 2010 22:32:37 -0700 (PDT)

From: Randy Dunlap <[email-masked]>
Date: Mon, 17 May 2010 11:01:12 -0700

> On 05/17/10 10:56, Stephen Hemminger wrote:
>> On Mon, 17 May 2010 09:17:56 -0700
>> Randy Dunlap <[email-masked]> wrote:
>> 
>>> From: Randy Dunlap <[email-masked]>
>>>
>>> Fix build when CONFIG_SYSFS is not enabled:
>>>
>>> net/bridge/br_if.c:136: error: 'struct net_bridge_port' has no member named 'sysfs_name'
>>>
>>> Signed-off-by: Randy Dunlap <[email-masked]>
...
>> I don't like peppering code with #ifdef like this.
> 
> Thanks.  I didn't like it either.
> 
>> Turns out that in this place sysfs_name is always the same
>> as the device name so instead:

Stephen, please give me a formal submission of this fix with proper
signoff and credit to Randy.

Thanks!