Subject: Re: linux-next: Tree for May 20 (radeon_pm build problem)

From: Randy Dunlap <[email-masked]>
Date: Thu, 20 May 2010 12:09:29 -0700

On Thu, 20 May 2010 16:30:42 +1000 Stephen Rothwell wrote:

> Hi all,
> 
> We are in the merge window again.  I remind you all not to add stuff for
> 2.6.36 to your linux-next trees until after 2.6.35-rc1.
> 
> Changes since 20100519:

CONFIG_DRM_RADEON=y
CONFIG_DRM_RADEON_KMS=y
CONFIG_POWER_SUPPLY=m

causes

radeon_pm.c:(.text+0x13d58f): undefined reference to `power_supply_is_system_supplied'
radeon_pm.c:(.text+0x13e72e): undefined reference to `power_supply_is_system_supplied'

The Kconfig for DRM_RADEON_KMS says:

config DRM_RADEON_KMS
	bool "Enable modesetting on radeon by default - NEW DRIVER"
	depends on DRM_RADEON
	depends on POWER_SUPPLY

Aha.  DRM_RADEON_KMS is a bool, so
	depends on DRM_RADEON && POWER_SUPPLY
evaluates to y.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***