From: Randy Dunlap <randy.dunlap@oracle•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
platform-driver-x86@vger•kernel.org
Cc: linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Thadeu Lima de Souza Cascardo <cascardo@holoscopio•com>,
Daniel Oliveira Nascimento <don@syst•com.br>,
Matthew Garrett <mjg@redhat•com>
Subject: [PATCH -next] x86/platform: classmate-laptop depends on RFKILL
Date: Sun, 23 May 2010 15:15:40 -0700 [thread overview]
Message-ID: <20100523151540.68e67298.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20100522170459.4c89723d.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle•com>
classmate-laptop uses rfkill interfaces, so it should depend on
RFKILL. Otherwise, when CONFIG_RFKILL=m, these build errors happen:
classmate-laptop.c:(.text+0x54b4f2): undefined reference to `rfkill_unregister'
classmate-laptop.c:(.text+0x54b508): undefined reference to `rfkill_destroy'
classmate-laptop.c:(.text+0x54b71a): undefined reference to `rfkill_alloc'
classmate-laptop.c:(.text+0x54b739): undefined reference to `rfkill_register'
classmate-laptop.c:(.text+0x54b761): undefined reference to `rfkill_destroy'
classmate-laptop.c:(.text+0x54b841): undefined reference to `rfkill_set_sw_state'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Thadeu Lima de Souza Cascardo <cascardo@holoscopio•com>
Cc: Daniel Oliveira Nascimento <don@syst•com.br>
Cc: platform-driver-x86@vger•kernel.org
Cc: Matthew Garrett <mjg@redhat•com>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20100522.orig/drivers/platform/x86/Kconfig
+++ linux-next-20100522/drivers/platform/x86/Kconfig
@@ -520,6 +520,7 @@ config TOSHIBA_BT_RFKILL
config ACPI_CMPC
tristate "CMPC Laptop Extras"
depends on X86 && ACPI
+ depends on RFKILL
select INPUT
select BACKLIGHT_CLASS_DEVICE
default n
next prev parent reply other threads:[~2010-05-23 22:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 7:04 linux-next: Tree for May 22 Stephen Rothwell
2010-05-23 22:15 ` Randy Dunlap [this message]
2010-05-23 23:33 ` [PATCH -next] platform/x86: msi-laptop depends on SERIO_I8042 Randy Dunlap
2010-05-28 17:24 ` Matthew Garrett
2010-05-24 0:00 ` [PATCH -next] nouveau: fix acpi_lid_open undefined Randy Dunlap
2010-05-24 0:09 ` Ben Skeggs
2010-05-24 12:56 ` Matthew Garrett
2010-05-24 13:53 ` Randy Dunlap
2010-05-24 13:59 ` Matthew Garrett
2010-05-24 14:17 ` Randy Dunlap
2010-05-24 22:47 ` Dave Airlie
2010-05-25 3:27 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100523151540.68e67298.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=cascardo@holoscopio$(echo .)com \
--cc=don@syst$(echo .)com.br \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mjg@redhat$(echo .)com \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox